New port: audio/vmpk: Virtual MIDI Piano Keyboard

[yuri]

Summary

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221460

[tcberner]

audio/vmpk/Makefile

24

Use CMAKE_BOOL=WITH_DBUS

24

ENABLE*

[yuri]

.

[yuri]

.

[tcberner]

[36/75] cd /wrkdirs/usr/ports/audio/vmpk/work/.build/man && /usr/local/bin/xsltproc --nonet --xinclude --xincludestyle --output /wrkdirs/usr/ports/audio/vmpk/work/.build/man/vmpk.1 http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl /wrkdirs/usr/ports/audio/vmpk/work/vmpk-0.6.2a/man/vmpk.xml
FAILED: man/vmpk.1 
cd /wrkdirs/usr/ports/audio/vmpk/work/.build/man && /usr/local/bin/xsltproc --nonet --xinclude --xincludestyle --output /wrkdirs/usr/ports/audio/vmpk/work/.build/man/vmpk.1 http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl /wrkdirs/usr/ports/audio/vmpk/work/vmpk-0.6.2a/man/vmpk.xml
I/O error : Attempt to load network entity http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl
warning: failed to load external entity "http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl"
cannot parse http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl

[yuri]

Fixed http download problem.
Added MANPAGES option.

[yuri]

In D13045#271154, @tcberner wrote:

Thanks for catching this! I fixed it.

[tcberner]

In D13045#271203, @yuri wrote:

In D13045#271154, @tcberner wrote:

Thanks for catching this! I fixed it.

No worries. Don't you need to add some magic to that option?

[yuri]

In D13045#271209, @tcberner wrote:

No worries. Don't you need to add some magic to that option?

They already have vmpk.1 file, but were still rebuilding it the hard way by default for some reason.

Downloading files like that, especially from http:// URLs, is a security problem. It is a MITM attack vulnerability.
A lot of projects have such problems, and linux packaging frameworks never catch such problems.
cmake itself has this problem, built into their specs. They allow ad-hoc fetch commands without the required fingerprint parameter.

I verified, it builds correctly now with MANPAGES on and off.

[tcberner]

Maybe add MANPAGES to options default sensible defaults and all :D -- I leave that up to you.

[mat]

head/audio/vmpk/Makefile

24–25 ↗

(On Diff #35125)

Why the MANPAGES option ? It installs 1 file, and does not add any dependency.

[mat]

ping.