Page MenuHomeFreeBSD

New port: audio/vmpk: Virtual MIDI Piano Keyboard
ClosedPublic

Authored by yuri on Nov 11 2017, 10:12 AM.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12662
Build 12933: arc lint + arc unit

Event Timeline

yuri created this revision.Nov 11 2017, 10:12 AM
tcberner added inline comments.Nov 11 2017, 10:40 AM
audio/vmpk/Makefile
24

Use CMAKE_BOOL=WITH_DBUS

24

ENABLE*

yuri updated this revision to Diff 35109.Nov 11 2017, 4:30 PM
yuri marked 2 inline comments as done.

.

[36/75] cd /wrkdirs/usr/ports/audio/vmpk/work/.build/man && /usr/local/bin/xsltproc --nonet --xinclude --xincludestyle --output /wrkdirs/usr/ports/audio/vmpk/work/.build/man/vmpk.1 http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl /wrkdirs/usr/ports/audio/vmpk/work/vmpk-0.6.2a/man/vmpk.xml
FAILED: man/vmpk.1 
cd /wrkdirs/usr/ports/audio/vmpk/work/.build/man && /usr/local/bin/xsltproc --nonet --xinclude --xincludestyle --output /wrkdirs/usr/ports/audio/vmpk/work/.build/man/vmpk.1 http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl /wrkdirs/usr/ports/audio/vmpk/work/vmpk-0.6.2a/man/vmpk.xml
I/O error : Attempt to load network entity http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl
warning: failed to load external entity "http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl"
cannot parse http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl
yuri updated this revision to Diff 35117.Nov 11 2017, 7:02 PM

Fixed http download problem.
Added MANPAGES option.

yuri added a comment.Nov 11 2017, 7:03 PM

Thanks for catching this! I fixed it.

In D13045#271203, @yuri wrote:

Thanks for catching this! I fixed it.

No worries. Don't you need to add some magic to that option?

yuri added a comment.Nov 11 2017, 7:22 PM

No worries. Don't you need to add some magic to that option?

They already have vmpk.1 file, but were still rebuilding it the hard way by default for some reason.

Downloading files like that, especially from http:// URLs, is a security problem. It is a MITM attack vulnerability.
A lot of projects have such problems, and linux packaging frameworks never catch such problems.
cmake itself has this problem, built into their specs. They allow ad-hoc fetch commands without the required fingerprint parameter.

I verified, it builds correctly now with MANPAGES on and off.

tcberner accepted this revision.Nov 11 2017, 7:41 PM

Maybe add MANPAGES to options default sensible defaults and all :D -- I leave that up to you.

This revision is now accepted and ready to land.Nov 11 2017, 7:41 PM
This revision was automatically updated to reflect the committed changes.
mat added inline comments.Nov 24 2017, 4:51 PM
head/audio/vmpk/Makefile
24–25 ↗(On Diff #35125)

Why the MANPAGES option ? It installs 1 file, and does not add any dependency.