Details
Details
- Reviewers
tcberner adamw - Commits
- rP453996: New port: audio/vmpk: Virtual MIDI Piano Keyboard
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
[36/75] cd /wrkdirs/usr/ports/audio/vmpk/work/.build/man && /usr/local/bin/xsltproc --nonet --xinclude --xincludestyle --output /wrkdirs/usr/ports/audio/vmpk/work/.build/man/vmpk.1 http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl /wrkdirs/usr/ports/audio/vmpk/work/vmpk-0.6.2a/man/vmpk.xml FAILED: man/vmpk.1 cd /wrkdirs/usr/ports/audio/vmpk/work/.build/man && /usr/local/bin/xsltproc --nonet --xinclude --xincludestyle --output /wrkdirs/usr/ports/audio/vmpk/work/.build/man/vmpk.1 http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl /wrkdirs/usr/ports/audio/vmpk/work/vmpk-0.6.2a/man/vmpk.xml I/O error : Attempt to load network entity http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl warning: failed to load external entity "http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl" cannot parse http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl
Comment Actions
They already have vmpk.1 file, but were still rebuilding it the hard way by default for some reason.
Downloading files like that, especially from http:// URLs, is a security problem. It is a MITM attack vulnerability.
A lot of projects have such problems, and linux packaging frameworks never catch such problems.
cmake itself has this problem, built into their specs. They allow ad-hoc fetch commands without the required fingerprint parameter.
I verified, it builds correctly now with MANPAGES on and off.
Comment Actions
Maybe add MANPAGES to options default sensible defaults and all :D -- I leave that up to you.
head/audio/vmpk/Makefile | ||
---|---|---|
24–25 | Why the MANPAGES option ? It installs 1 file, and does not add any dependency. |