Page MenuHomeFreeBSD

New port: audio/vmpk: Virtual MIDI Piano Keyboard
ClosedPublic

Authored by yuri on Nov 11 2017, 10:12 AM.
Tags
None
Referenced Files
F82043754: D13045.id35109.diff
Wed, Apr 24, 10:47 PM
Unknown Object (File)
Tue, Apr 23, 9:44 PM
Unknown Object (File)
Tue, Apr 23, 9:04 PM
Unknown Object (File)
Fri, Apr 19, 1:23 PM
Unknown Object (File)
Mar 22 2024, 7:21 PM
Unknown Object (File)
Mar 22 2024, 7:21 PM
Unknown Object (File)
Mar 22 2024, 7:21 PM
Unknown Object (File)
Mar 22 2024, 7:21 PM
Subscribers

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

audio/vmpk/Makefile
23 ↗(On Diff #35095)

Use CMAKE_BOOL=WITH_DBUS

23 ↗(On Diff #35095)

ENABLE*

yuri marked 2 inline comments as done.

.

[36/75] cd /wrkdirs/usr/ports/audio/vmpk/work/.build/man && /usr/local/bin/xsltproc --nonet --xinclude --xincludestyle --output /wrkdirs/usr/ports/audio/vmpk/work/.build/man/vmpk.1 http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl /wrkdirs/usr/ports/audio/vmpk/work/vmpk-0.6.2a/man/vmpk.xml
FAILED: man/vmpk.1 
cd /wrkdirs/usr/ports/audio/vmpk/work/.build/man && /usr/local/bin/xsltproc --nonet --xinclude --xincludestyle --output /wrkdirs/usr/ports/audio/vmpk/work/.build/man/vmpk.1 http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl /wrkdirs/usr/ports/audio/vmpk/work/vmpk-0.6.2a/man/vmpk.xml
I/O error : Attempt to load network entity http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl
warning: failed to load external entity "http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl"
cannot parse http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl

Fixed http download problem.
Added MANPAGES option.

Thanks for catching this! I fixed it.

In D13045#271203, @yuri wrote:

Thanks for catching this! I fixed it.

No worries. Don't you need to add some magic to that option?

No worries. Don't you need to add some magic to that option?

They already have vmpk.1 file, but were still rebuilding it the hard way by default for some reason.

Downloading files like that, especially from http:// URLs, is a security problem. It is a MITM attack vulnerability.
A lot of projects have such problems, and linux packaging frameworks never catch such problems.
cmake itself has this problem, built into their specs. They allow ad-hoc fetch commands without the required fingerprint parameter.

I verified, it builds correctly now with MANPAGES on and off.

Maybe add MANPAGES to options default sensible defaults and all :D -- I leave that up to you.

This revision is now accepted and ready to land.Nov 11 2017, 7:41 PM
This revision was automatically updated to reflect the committed changes.
head/audio/vmpk/Makefile
24–25

Why the MANPAGES option ? It installs 1 file, and does not add any dependency.