Paths

Table of Contentst

vnic: correct and simplify SIOCSIFFLAGS ioctl
ClosedPublic
Actions

Authored by emaste on Nov 10 2017, 2:36 PM.

Tags

None

Referenced Files

	F170581572: D13028.id35035.diff
	Sat, Sep 5, 12:26 PM

	F170503061: D13028.diff
	Sat, Sep 5, 3:24 AM

	F170501507: D13028.id61530.diff
	Sat, Sep 5, 3:13 AM

	F170441586: D13028.id35035.diff
	Fri, Sep 4, 8:32 PM

	F170395196: D13028.id35036.diff
	Fri, Sep 4, 3:08 PM

	Unknown Object (File)
	Fri, Sep 4, 9:49 AM

	Unknown Object (File)
	Fri, Sep 4, 6:53 AM

	Unknown Object (File)
	Fri, Sep 4, 2:39 AM

View All Files

Subscribers

imp

Details

Reviewers

bz
andrew

Commits

rS351664: vnic: correct and simplify SIOCSIFFLAGS

Summary

flags variable was unused, and the IFF_PROMISC logic was broken. Rework and simplify.

Should be a nop because promisc & allmulti don't do anything yet anyhow.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste created this revision.Nov 10 2017, 2:36 PM

undo accidental if_getdrvflags breakage

rebase

This revision was not accepted when it landed; it landed in state Needs Review.Sep 1 2019, 4:53 PM

Closed by commit rS351664: vnic: correct and simplify SIOCSIFFLAGS (authored by emaste). · Explain Why

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rS351664: vnic: correct and simplify SIOCSIFFLAGS.

Herald added a subscriber: imp. · View Herald TranscriptSep 1 2019, 4:53 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

vnic/

nicvf_main.c

12 lines

Diff 61530

View Options

head/sys/dev/vnic/nicvf_main.c

vnic: correct and simplify SIOCSIFFLAGS ioctlClosedPublicActions