Page MenuHomeFreeBSD
Differential D12888

Remove object_collapses and object_bypasses counters
AbandonedPublic
Actions

Authored by mjg on Nov 1 2017, 8:15 AM.
Tags
None
Referenced Files
F151319198: D12888.id.diff
Tue, Apr 7, 1:58 PM
Unknown Object (File)
Tue, Apr 7, 6:02 AM
Unknown Object (File)
Mon, Apr 6, 8:26 AM
Unknown Object (File)
Sun, Apr 5, 3:19 PM
Unknown Object (File)
Sat, Mar 28, 6:21 AM
Unknown Object (File)
Thu, Mar 26, 1:55 PM
Unknown Object (File)
Tue, Mar 24, 11:27 AM
Unknown Object (File)
Tue, Mar 24, 11:27 AM
View All 58 Files
Subscribers
imp

Details

Reviewers
alc
markj
kib
Summary

Spotted during crusade to reduce false-sharing. If someone wants to change them into less unfriendly counters or whatever I'm happy to drop this diff.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 12355

Event Timeline

mjg created this revision.Nov 1 2017, 8:15 AM
Herald added a subscriber: imp. · View Herald TranscriptNov 1 2017, 8:15 AM
alc added a comment.Nov 2 2017, 5:08 PM

On a occasion, I do look at these counters. Converting them to an SMP-friendly alternative is probably a worthwhile endeavor.

kib added a comment.Nov 3 2017, 11:05 AM
In D12888#268165, @alc wrote:

On a occasion, I do look at these counters. Converting them to an SMP-friendly alternative is probably a worthwhile endeavor.

This is very similar to what I said to Mateusz in the private discussion. In particular, the counters were the key clues in the investigation of bugs fixed by https://www.freebsd.org/security/advisories/FreeBSD-EN-16:17.vm.asc

alc added a comment.Dec 24 2017, 9:41 PM

See D13611.

alc added a comment.Dec 26 2017, 8:07 PM

Can we abandon this change now?

mjg abandoned this revision.Dec 27 2017, 9:32 PM

Revision Contents
Changeset List

PathSize
sys/
vm/
13 lines

Diff 34584

View Options

sys/vm/vm_object.c

Loading...