Remove object_collapses and object_bypasses counters
AbandonedPublic
Actions

Authored by mjg on Nov 1 2017, 8:15 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Aug 26, 10:47 AM

	Unknown Object (File)
	Wed, Aug 26, 10:12 AM

	Unknown Object (File)
	Wed, Aug 26, 9:16 AM

	Unknown Object (File)
	Wed, Aug 19, 8:09 PM

	Unknown Object (File)
	Wed, Aug 12, 1:50 PM

	Unknown Object (File)
	Sat, Aug 8, 12:53 AM

	Unknown Object (File)
	Fri, Aug 7, 12:49 PM

	Unknown Object (File)
	Jul 6 2026, 1:03 AM

View All 70 Files

Subscribers

imp

Details

Reviewers

alc
markj
kib

Summary

Spotted during crusade to reduce false-sharing. If someone wants to change them into less unfriendly counters or whatever I'm happy to drop this diff.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 12355

Event Timeline

mjg created this revision.Nov 1 2017, 8:15 AM

Herald added a subscriber: imp. · View Herald TranscriptNov 1 2017, 8:15 AM

On a occasion, I do look at these counters. Converting them to an SMP-friendly alternative is probably a worthwhile endeavor.

In D12888#268165, @alc wrote:

On a occasion, I do look at these counters. Converting them to an SMP-friendly alternative is probably a worthwhile endeavor.

This is very similar to what I said to Mateusz in the private discussion. In particular, the counters were the key clues in the investigation of bugs fixed by https://www.freebsd.org/security/advisories/FreeBSD-EN-16:17.vm.asc

See D13611.

Can we abandon this change now?

mjg abandoned this revision.Dec 27 2017, 9:32 PM

Revision Contents
Changeset List

Path

Size

sys/

vm/

vm_object.c

13 lines

Diff 34584

View Options

Remove object_collapses and object_bypasses countersAbandonedPublicActions