Page MenuHomeFreeBSD

Remove object_collapses and object_bypasses counters
AbandonedPublic

Authored by mjg on Nov 1 2017, 8:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 9, 3:18 AM
Unknown Object (File)
Dec 7 2024, 5:08 AM
Unknown Object (File)
Nov 12 2024, 11:24 PM
Unknown Object (File)
Nov 12 2024, 10:05 AM
Unknown Object (File)
Nov 12 2024, 12:00 AM
Unknown Object (File)
Nov 11 2024, 10:12 PM
Unknown Object (File)
Nov 11 2024, 10:11 PM
Unknown Object (File)
Nov 11 2024, 10:11 PM
Subscribers

Details

Reviewers
alc
markj
kib
Summary

Spotted during crusade to reduce false-sharing. If someone wants to change them into less unfriendly counters or whatever I'm happy to drop this diff.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 12355

Event Timeline

On a occasion, I do look at these counters. Converting them to an SMP-friendly alternative is probably a worthwhile endeavor.

In D12888#268165, @alc wrote:

On a occasion, I do look at these counters. Converting them to an SMP-friendly alternative is probably a worthwhile endeavor.

This is very similar to what I said to Mateusz in the private discussion. In particular, the counters were the key clues in the investigation of bugs fixed by https://www.freebsd.org/security/advisories/FreeBSD-EN-16:17.vm.asc

Can we abandon this change now?