Page MenuHomeFreeBSD

loader.efi: Make framebuffer commands available for arm64
ClosedPublic

Authored by manu on Oct 22 2017, 12:05 PM.
Tags
None
Referenced Files
F106655316: D12757.diff
Fri, Jan 3, 11:26 AM
Unknown Object (File)
Sat, Dec 21, 4:05 AM
Unknown Object (File)
Dec 4 2024, 1:00 AM
Unknown Object (File)
Dec 3 2024, 8:20 PM
Unknown Object (File)
Nov 4 2024, 8:40 PM
Unknown Object (File)
Sep 29 2024, 4:18 PM
Unknown Object (File)
Sep 16 2024, 2:06 AM
Unknown Object (File)
Sep 11 2024, 6:01 PM
Subscribers

Details

Summary

Move framebuffer.{c,h} to sys/boot/efi/loader and add the efifb
related metadata and pass it to the kernel

Test Plan

Tested On: Pine64

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This looks good. One note for posterity that's likely a big swamp to drain so isn't gating this commit.

sys/boot/efi/loader/bootinfo.c
251 ↗(On Diff #34230)

This is fine for this commit, however...

I'm starting to think that we need to overhaul the loader's #defines for stuff like this. LOADER_FOO_SUPPORT isn't quite right.

Somethign to think about.

This revision is now accepted and ready to land.Oct 22 2017, 3:04 PM
andrew added inline comments.
sys/boot/efi/loader/bootinfo.c
251 ↗(On Diff #34230)

Do we even need this #if?

sys/boot/efi/loader/bootinfo.c
251 ↗(On Diff #34230)

For now yes and I didn't tested on arm (I will commit with defined(arm) removed.
After that I'm not sure we need it.

This revision was automatically updated to reflect the committed changes.