Page MenuHomeFreeBSD

loader.efi: Make framebuffer commands available for arm64
ClosedPublic

Authored by manu on Oct 22 2017, 12:05 PM.
Tags
None
Referenced Files
F82913440: D12757.diff
Fri, May 3, 10:18 PM
Unknown Object (File)
Dec 20 2023, 4:10 AM
Unknown Object (File)
Nov 16 2023, 8:27 PM
Unknown Object (File)
Nov 14 2023, 3:01 PM
Unknown Object (File)
Nov 4 2023, 8:43 PM
Unknown Object (File)
Oct 13 2023, 8:28 PM
Unknown Object (File)
Oct 13 2023, 2:02 PM
Unknown Object (File)
Oct 13 2023, 7:23 AM
Subscribers

Details

Summary

Move framebuffer.{c,h} to sys/boot/efi/loader and add the efifb
related metadata and pass it to the kernel

Test Plan

Tested On: Pine64

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 12174
Build 12473: arc lint + arc unit

Event Timeline

This looks good. One note for posterity that's likely a big swamp to drain so isn't gating this commit.

sys/boot/efi/loader/bootinfo.c
251

This is fine for this commit, however...

I'm starting to think that we need to overhaul the loader's #defines for stuff like this. LOADER_FOO_SUPPORT isn't quite right.

Somethign to think about.

This revision is now accepted and ready to land.Oct 22 2017, 3:04 PM
andrew added inline comments.
sys/boot/efi/loader/bootinfo.c
251

Do we even need this #if?

sys/boot/efi/loader/bootinfo.c
251

For now yes and I didn't tested on arm (I will commit with defined(arm) removed.
After that I'm not sure we need it.

This revision was automatically updated to reflect the committed changes.