Page MenuHomeFreeBSD

www/groupoffice: Update from 6.2.61 to 6.2.63
ClosedPublic

Authored by joneum on Oct 17 2017, 8:43 PM.

Details

Summary

www/groupoffice: Update from 6.2.61 to 6.2.63

-Changelog: https://sourceforge.net/p/group-office/code/HEAD/tree/branches/groupoffice-6.2/www/CHANGELOG.TXT

Approved by: xxx (mentor)
#Differential Revision: https://reviews.freebsd.org/Dxxxxx

Test Plan

~/dev/ports/www/groupoffice % portlint -AC
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: "RESTRICTED" found. do not forget to update ports/LEGAL.
0 fatal errors and 3 warnings found.

poudriere testport:

10.3-amd64
10.3-i386
11.1-amd64
11.1-i386
12.0-CURRENT r323123 amd64
12.0-CURRENT r323123 i386

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

www/groupoffice/Makefile
5 ↗(On Diff #34076)

You could switch this to DISTVERSION while here.

As a further comment to the DISTVERSION comment, have a look at 5.2.2 VERSIONS:
https://www.freebsd.org/doc/en/books/porters-handbook/book.html#makefile-naming

DISTVERSION should be the default to set. Over the time PORTVERSION was used over DISTVERSION just because of habits. So if you spot a PORTVERSION were a DISTVERSION is right please replace it.

Change PORTVERSION to DISTVERSION

In D12705#263790, @tz wrote:

As a further comment to the DISTVERSION comment, have a look at 5.2.2 VERSIONS:
https://www.freebsd.org/doc/en/books/porters-handbook/book.html#makefile-naming

DISTVERSION should be the default to set. Over the time PORTVERSION was used over DISTVERSION just because of habits. So if you spot a PORTVERSION were a DISTVERSION is right please replace it.

Thanks to both of you! That was new to me. I will take it from now on! :-)

www/groupoffice/Makefile
5 ↗(On Diff #34076)

Portlint will likely tell you to reoder the two lines :)

Apart from the previous comment, it looks good to me.

This revision is now accepted and ready to land.Oct 18 2017, 6:20 PM
This revision was automatically updated to reflect the committed changes.
head/www/groupoffice/Makefile
5–6

This is out of order.