Page MenuHomeFreeBSD

usr.sbin/ctld: fix a segfault on duplicate lun or target when using ucl conf format
ClosedPublic

Authored by nikita_elyzion.net on Oct 12 2017, 4:02 PM.
Tags
None
Referenced Files
F111195814: D12646.diff
Fri, Feb 28, 4:54 PM
Unknown Object (File)
Mon, Feb 10, 11:12 AM
Unknown Object (File)
Mon, Feb 3, 6:05 PM
Unknown Object (File)
Mon, Feb 3, 6:03 PM
Unknown Object (File)
Thu, Jan 30, 4:22 PM
Unknown Object (File)
Jan 25 2025, 7:32 PM
Unknown Object (File)
Jan 21 2025, 5:40 PM
Unknown Object (File)
Jan 18 2025, 5:35 PM
Subscribers

Details

Summary

When using ucl conf file format for ctld, having a duplicate lun or target make ctld segfault with :

(lldb) target create "/usr/sbin/ctld" --core "./ctld.core"
Core file '/root/./ctld.core' (x86_64) was loaded.
(lldb) bt
* thread #1, name = 'ctld', stop reason = signal SIGSEGV
  * frame #0: ctld`uclparse_conf [inlined] uclparse_target at uclparse.c:637
    frame #1: ctld`uclparse_conf at uclparse.c:374
    frame #2: ctld`uclparse_conf(newconf=<unavailable>, path=<unavailable>) at uclparse.c:919
    frame #3: ctld`conf_new_from_file(path="", oldconf=<unavailable>, ucl=<unavailable>) at ctld.c:2576
    frame #4: ctld`main(argc=<unavailable>, argv=<unavailable>) at ctld.c:2693
    frame #5: 0x0000000000402f0f ctld`_start + 383

This patch check that target_new() and lun_new() succeed.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped