Page MenuHomeFreeBSD

Restore the ability to deregister an eventhandler callback from within the callback.
ClosedPublic

Authored by ian on Oct 1 2017, 8:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 11, 11:49 PM
Unknown Object (File)
Mon, Nov 11, 11:34 PM
Unknown Object (File)
Mon, Nov 11, 9:37 PM
Unknown Object (File)
Mon, Nov 11, 7:17 PM
Unknown Object (File)
Mon, Nov 11, 6:34 PM
Unknown Object (File)
Sep 24 2024, 6:49 PM
Unknown Object (File)
Sep 24 2024, 2:32 PM
Unknown Object (File)
Sep 23 2024, 5:44 PM
Subscribers

Details

Summary

When the EVENTHANDLER(9) subsystem was created, it was a documented feature that an eventhandler callback function could safely deregister itself. In r200652 that feature was inadvertantly broken by adding drain-wait logic to eventhandler_deregister(), so that it would be safe to unload a module upon return from deregistering its event handlers.

There are now 145 callers of EVENTHANDLER_DEREGISTER(), and it's likely many of them are depending on the drain-wait logic that has been in place for 8 years. So instead of creating a separate eventhandler_drain() and adding it to some or all of those 145 call sites, this creates a separate eventhandler_drain_nowait() function for the specific purpose of deregistering a callback from within the running callback.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I don't see anything horrible here.

This revision is now accepted and ready to land.Oct 1 2017, 9:58 PM
This revision was automatically updated to reflect the committed changes.