vfs_export: Simplify vfs_export_lookup
ClosedPublic
Actions

Authored by manu on Sep 26 2017, 11:35 AM.

Details

Reviewers

kib
rmacklem
bapt

Commits

rS324054: vfs_export: Simplify vfs_export_lookup

Summary

If the filesystem is not exported directly return NULL.
If no address is given and filesystem is exported using some default one
return it directly, if it doesn't have a default one directly return NULL.

MFC After: 1 week
Sponsored-By: Gandi.net

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

manu created this revision.Sep 26 2017, 11:35 AM

Herald added a subscriber: imp. · View Herald TranscriptSep 26 2017, 11:35 AM

kib added inline comments.Sep 26 2017, 11:58 AM

sys/kern/vfs_export.c
465 ↗	(On Diff #33442)	`if ((mp->mnt_flag & MNT_DEFEXPORTED) != 0)`
467 ↗	(On Diff #33442)	You do not need `else`
488 ↗	(On Diff #33442)	Use 4-spaces indent for continuation.
489 ↗	(On Diff #33442)	`if (np != NULL && (np->...->rn_flags & RNF_ROOT) != 0)`
490 ↗	(On Diff #33442)	You might `return (NULL)` there directly as well.

Address kib's comments.

manu marked 5 inline comments as done.Sep 26 2017, 12:11 PM

bapt accepted this revision.Sep 26 2017, 12:18 PM

This revision is now accepted and ready to land.Sep 26 2017, 12:18 PM

kib accepted this revision.Sep 26 2017, 1:43 PM

kib added inline comments.

sys/kern/vfs_export.c
487 ↗	(On Diff #33445)	`if (np != NULL && ..`

Closed by commit rS324054: vfs_export: Simplify vfs_export_lookup (authored by manu). · Explain WhySep 27 2017, 9:39 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

vfs_export.c

64 lines

Diff 33486

View Options

head/sys/kern/vfs_export.c

vfs_export: Simplify vfs_export_lookupClosedPublicActions