devel/buildbot*: Rename all buildbot ports devel/buildbot -> devel/py-buildbot devel/buildbot-worker -> devel/py-buildbot-worker devel/buildbot-console-view -> devel/py-buildbot-console-view devel/buildbot-grid-view -> devel/py-buildbot-grid-view devel/buildbot-pkg -> devel/py-buildbot-pkg devel/buildbot-waterfall-view -> devel/py-buildbot-waterfall-view devel/buildbot-www -> devel/py-buildbot-www - Update MAINTAINER - Allow builds with Python 3.x Reviewed_by: koobs Approved by: koobs (maintainer), portmgr (maintainer timeout, grembo, 3+ weeks) Differential_Revision: D12499
Details
Details
- portlint: OK (all ports)
- testport: OK (poudriere: 10.3-RELEASE-amd64, Python 2.7)
- maketest: OK (4 tests failing, 5060 passing for buildbot, 0 tests failing, 229 passing for buildbot-worker)
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 11782 Build 12126: arc lint + arc unit
Event Timeline
Comment Actions
All ports:
- Add PKGNAMEPREFIX=${PYTHON_PKGNAMEPREFIX}
- Add LICENCE_FILE=WRKSRC/path/to/file if/where one exists in WRKSRC (DISTFILES)
- Add and verify USE_PYTHON=concurrent
- Update USES=python to allow 2/3 (removed in previous review)
- Update MAINTAINER=koobs@FreeBSD.org (or take maintainership). All buildbot ports should be maintained by the same person. Some are already different
- Update COMMENT to match that in setup.py:description examplt buildbot-pkg COMMENT=Buildbot packaging tools
General:
- Add MOVED entries
| devel/py-buildbot-www/Makefile | ||
|---|---|---|
| 14 | Add LICENCE_FILE=WRKSRC/path/to/file if/where one exists in WRKSRC (DISTFILES) | |
| devel/py-buildbot/Makefile | ||
| 10–11 | Update MAINTAINER=koobs@FreeBSD.org (all ports, or take maintainership) | |
| 11–12 | No longer called master, update (bit) | |
| 34 | Revert to allow 2/3 | |
| 36 | Add and verify concurrent support | |
| devel/py-buildbot/Makefile | ||
|---|---|---|
| 36 | All files are uniquely named (are version suffixed), between Python 2.x and 3.x built versions, in path locations are not python version specific, so that concurrently installed port versions have no conflicting files. USE_PYTHON=concurrent is not perfect (eg: does not currently suffix man files) In particular:
concurrent does some/most things automatically, but check final results | |
Comment Actions
We are not ready to make these ports as concurrent yet.
There are still some conflicts.
Comment Actions
@koobs I removed concurrent from these Makefiles. We aren't ready to do that yet, since there are conflicts.
The port works on Python 3 though, so removing 2.7 as a restriction is OK.
| devel/py-buildbot/Makefile | ||
|---|---|---|
| 35 | Minor nit, independent of what version our mock port is, but this is probably >= | |