Allow LOADER_TFTP_SUPPORT to work again

[sbruno]

Summary

LOADER_TFTP_SUPPORT seems to have been broken by the update in svn r318987.

Test Plan

Build PXE loader with LOADER_TFTP_SUPPORT defined and verify that MFS/Kernel are loaded via tftp server.

[imp]

[tsoome]

This is busting all the effort of avoiding to define tftp or NFS at build time, isn’t it?

[sbruno]

In D12466#258416, @tsoome wrote:

This is busting all the effort of avoiding to define tftp or NFS at build time, isn’t it?

I'm unsure as what I can tell is that the current version of pxeboot won't tftp an MFSroot + Kernel in its current state.

Its possible that I just don't know what the magical incantation is in dhcpd.conf to get it to work right, but tcpdump doesn't show a TFTP req if this code isn't in place.

[tsoome]

In D12466#258432, @sbruno wrote:

In D12466#258416, @tsoome wrote:

This is busting all the effort of avoiding to define tftp or NFS at build time, isn’t it?

I'm unsure as what I can tell is that the current version of pxeboot won't tftp an MFSroot + Kernel in its current state.

Its possible that I just don't know what the magical incantation is in dhcpd.conf to get it to work right, but tcpdump doesn't show a TFTP req if this code isn't in place.

I can not check the man pxeboot right now, but we have tftp:// prefix etc. I am not sure if the man has received the update, or it is just a,bout the source.

[sbruno]

In D12466#258441, @tsoome wrote:

In D12466#258432, @sbruno wrote:

In D12466#258416, @tsoome wrote:

This is busting all the effort of avoiding to define tftp or NFS at build time, isn’t it?

I'm unsure as what I can tell is that the current version of pxeboot won't tftp an MFSroot + Kernel in its current state.

Its possible that I just don't know what the magical incantation is in dhcpd.conf to get it to work right, but tcpdump doesn't show a TFTP req if this code isn't in place.

I can not check the man pxeboot right now, but we have tftp:// prefix etc. I am not sure if the man has received the update, or it is just a,bout the source.

Indeed. My assumption was that using tftp://IP/<path> or tftp:/<path>/ would work. It does not.

[tsoome]

In D12466#258441, @tsoome wrote:

In D12466#258432, @sbruno wrote:

In D12466#258416, @tsoome wrote:

This is busting all the effort of avoiding to define tftp or NFS at build time, isn’t it?

I'm unsure as what I can tell is that the current version of pxeboot won't tftp an MFSroot + Kernel in its current state.

Its possible that I just don't know what the magical incantation is in dhcpd.conf to get it to work right, but tcpdump doesn't show a TFTP req if this code isn't in place.

I can not check the man pxeboot right now, but we have tftp:// prefix etc. I am not sure if the man has received the update, or it is just a,bout the source.

yep, pxeboot man does provide examples.

In D12466#258459, @sbruno wrote:

In D12466#258441, @tsoome wrote:

In D12466#258432, @sbruno wrote:

In D12466#258416, @tsoome wrote:

This is busting all the effort of avoiding to define tftp or NFS at build time, isn’t it?

I'm unsure as what I can tell is that the current version of pxeboot won't tftp an MFSroot + Kernel in its current state.

Its possible that I just don't know what the magical incantation is in dhcpd.conf to get it to work right, but tcpdump doesn't show a TFTP req if this code isn't in place.

I can not check the man pxeboot right now, but we have tftp:// prefix etc. I am not sure if the man has received the update, or it is just a,bout the source.

Indeed. My assumption was that using tftp://IP/<path> or tftp:/<path>/ would work. It does not.

There is one issue I have found; and thats about the dhcp.conf, apparently the user-class option may need different approach on check:

if substring (option user-class, 1, 7) = "illumos" {
      option root-path "nfs://192.168.1.244/export/uefi-oi";
}

thats what I have in my isc dhcpd4.conf - of course for freebsd you would need to replace the user class name.

[sbruno]

I went back to the man page, just to validate. I used the example from the man page after rebuilding pxeboot with *defaults*. It defintely does not TFTP in this case.

If I recompile with LOADER_TFTP_SUPPORT=y and this patch, it works.

subnet 192.168.100.0 netmask 255.255.255.0 {               
  option        broadcast-address       192.168.100.255;   
  option        routers                 192.168.100.1;     
  option        domain-name-servers     192.168.0.1;       
  option        subnet-mask             255.255.255.0;     
  option        tftp-server             192.168.100.1;     
  next-server                           192.168.100.1;     

  if exists user-class and option user-class = "FreeBSD" { 
        option root-path "tftp://192.168.100.1/tftpboot/"; 
  }                                                        

  host QEMU {                                              
    hardware ethernet 52:54:00:12:34:56;                   
    fixed-address 192.168.100.55;                          
    filename "/boot/pxeboot.mfs";                          
  }   
}

[sbruno]

The issues I was running into seem to be related to my attempts to use the old way/old documentation. I can tftp a kernel/ramdisk with the default options.