Page MenuHomeFreeBSD

mbuf: Remove UDP_IPV4_EX, which is never defined.
ClosedPublic

Authored by sepherosa_gmail.com on Sep 22 2017, 5:36 AM.
Tags
None
Referenced Files
F110440670: D12453.diff
Tue, Feb 18, 12:28 PM
Unknown Object (File)
Tue, Feb 11, 4:10 AM
Unknown Object (File)
Tue, Jan 28, 4:44 PM
Unknown Object (File)
Fri, Jan 24, 7:08 PM
Unknown Object (File)
Fri, Jan 24, 5:38 PM
Unknown Object (File)
Jan 9 2025, 6:14 PM
Unknown Object (File)
Jan 1 2025, 10:36 PM
Unknown Object (File)
Oct 21 2024, 6:37 PM
Subscribers
None

Details

Summary
Add comment to explain the IPV6_EX suffix.  The confusion about
these RSS hash type probably stems from the facts that they were
never widely implemented by hardwares.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

This seems generally sensible.

I'm not quite sure about keeping the "Non-standard RSS hash types" comment, as M_HASHTYPE_OPAQUE is basically intended to be a catch-all for any other model, and is not specifically intended to be RSS (hence not having RSS in its name). So I'd be tempted to drop that comment.

This revision is now accepted and ready to land.Sep 22 2017, 12:21 PM

This seems generally sensible.

I'm not quite sure about keeping the "Non-standard RSS hash types" comment, as M_HASHTYPE_OPAQUE is basically intended to be a catch-all for any other model, and is not specifically intended to be RSS (hence not having RSS in its name). So I'd be tempted to drop that comment.

OK, sure.

This revision was automatically updated to reflect the committed changes.