Page MenuHomeFreeBSD

mbuf: Remove UDP_IPV4_EX, which is never defined.
ClosedPublic

Authored by sepherosa_gmail.com on Sep 22 2017, 5:36 AM.

Details

Summary
Add comment to explain the IPV6_EX suffix.  The confusion about
these RSS hash type probably stems from the facts that they were
never widely implemented by hardwares.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

rwatson accepted this revision.Sep 22 2017, 12:21 PM

This seems generally sensible.

I'm not quite sure about keeping the "Non-standard RSS hash types" comment, as M_HASHTYPE_OPAQUE is basically intended to be a catch-all for any other model, and is not specifically intended to be RSS (hence not having RSS in its name). So I'd be tempted to drop that comment.

This revision is now accepted and ready to land.Sep 22 2017, 12:21 PM

This seems generally sensible.
I'm not quite sure about keeping the "Non-standard RSS hash types" comment, as M_HASHTYPE_OPAQUE is basically intended to be a catch-all for any other model, and is not specifically intended to be RSS (hence not having RSS in its name). So I'd be tempted to drop that comment.

OK, sure.

This revision was automatically updated to reflect the committed changes.