Page MenuHomeFreeBSD

Don't complain about missing mountpoints for scripted installations.
ClosedPublic

Authored by rpokala on Sep 12 2017, 9:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 9, 11:10 PM
Unknown Object (File)
Wed, Aug 26, 9:40 AM
Unknown Object (File)
Wed, Aug 19, 4:25 AM
Unknown Object (File)
Aug 13 2026, 9:05 PM
Unknown Object (File)
Aug 12 2026, 4:54 PM
Unknown Object (File)
Aug 10 2026, 9:32 PM
Unknown Object (File)
Aug 10 2026, 2:19 PM
Unknown Object (File)
Aug 8 2026, 6:09 PM

Details

Summary

Don't bother with an interactive prompt for scripted installs; assume the person who wrote the script knew what they were doing, and proceed.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dteske added inline comments.
usr.sbin/bsdinstall/partedit/gpart_ops.c
1055–1056 ↗(On Diff #32990)

"choice = 0;" can be moved above the "if (interactive) {" line to eliminate the need for an "} else {" (improves readability imho)

Address dteske's comment by unconditionally setting "choice", and overriding it
for the interactive case.

This revision is now accepted and ready to land.Sep 12 2017, 9:59 PM
This revision was automatically updated to reflect the committed changes.