Page MenuHomeFreeBSD

Don't complain about missing mountpoints for scripted installations.
ClosedPublic

Authored by rpokala on Sep 12 2017, 9:42 PM.
Tags
None
Referenced Files
F133448467: D12346.diff
Sat, Oct 25, 9:22 PM
Unknown Object (File)
Mon, Oct 20, 1:58 PM
Unknown Object (File)
Wed, Oct 8, 8:26 PM
Unknown Object (File)
Sep 26 2025, 9:38 AM
Unknown Object (File)
Sep 22 2025, 11:55 PM
Unknown Object (File)
Sep 11 2025, 12:57 PM
Unknown Object (File)
Sep 3 2025, 5:28 PM
Unknown Object (File)
Sep 3 2025, 10:00 AM

Details

Summary

Don't bother with an interactive prompt for scripted installs; assume the person who wrote the script knew what they were doing, and proceed.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dteske added inline comments.
usr.sbin/bsdinstall/partedit/gpart_ops.c
1055–1056 ↗(On Diff #32990)

"choice = 0;" can be moved above the "if (interactive) {" line to eliminate the need for an "} else {" (improves readability imho)

Address dteske's comment by unconditionally setting "choice", and overriding it
for the interactive case.

This revision is now accepted and ready to land.Sep 12 2017, 9:59 PM
This revision was automatically updated to reflect the committed changes.