Page MenuHomeFreeBSD

Don't complain about missing mountpoints for scripted installations.
ClosedPublic

Authored by rpokala on Sep 12 2017, 9:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 17, 2:35 PM
Unknown Object (File)
Thu, Dec 26, 8:34 PM
Unknown Object (File)
Dec 13 2024, 1:32 PM
Unknown Object (File)
Dec 4 2024, 8:52 AM
Unknown Object (File)
Nov 17 2024, 2:35 PM
Unknown Object (File)
Nov 17 2024, 2:16 PM
Unknown Object (File)
Nov 17 2024, 2:16 PM
Unknown Object (File)
Oct 1 2024, 7:31 AM

Details

Summary

Don't bother with an interactive prompt for scripted installs; assume the person who wrote the script knew what they were doing, and proceed.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dteske added inline comments.
usr.sbin/bsdinstall/partedit/gpart_ops.c
1055–1056 ↗(On Diff #32990)

"choice = 0;" can be moved above the "if (interactive) {" line to eliminate the need for an "} else {" (improves readability imho)

Address dteske's comment by unconditionally setting "choice", and overriding it
for the interactive case.

This revision is now accepted and ready to land.Sep 12 2017, 9:59 PM
This revision was automatically updated to reflect the committed changes.