Page MenuHomeFreeBSD

Don't complain about missing mountpoints for scripted installations.
ClosedPublic

Authored by rpokala on Sep 12 2017, 9:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 8, 8:26 PM
Unknown Object (File)
Fri, Sep 26, 9:38 AM
Unknown Object (File)
Mon, Sep 22, 11:55 PM
Unknown Object (File)
Thu, Sep 11, 12:57 PM
Unknown Object (File)
Sep 3 2025, 5:28 PM
Unknown Object (File)
Sep 3 2025, 10:00 AM
Unknown Object (File)
Aug 30 2025, 9:10 PM
Unknown Object (File)
Aug 13 2025, 2:34 PM

Details

Summary

Don't bother with an interactive prompt for scripted installs; assume the person who wrote the script knew what they were doing, and proceed.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dteske added inline comments.
usr.sbin/bsdinstall/partedit/gpart_ops.c
1055–1056 ↗(On Diff #32990)

"choice = 0;" can be moved above the "if (interactive) {" line to eliminate the need for an "} else {" (improves readability imho)

Address dteske's comment by unconditionally setting "choice", and overriding it
for the interactive case.

This revision is now accepted and ready to land.Sep 12 2017, 9:59 PM
This revision was automatically updated to reflect the committed changes.