Differential D12346

Don't complain about missing mountpoints for scripted installations.
ClosedPublic
Actions

Authored by rpokala on Sep 12 2017, 9:42 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Aug 13, 9:05 PM

	Unknown Object (File)
	Wed, Aug 12, 4:54 PM

	Unknown Object (File)
	Mon, Aug 10, 9:32 PM

	Unknown Object (File)
	Mon, Aug 10, 2:19 PM

	Unknown Object (File)
	Sat, Aug 8, 6:09 PM

	Unknown Object (File)
	Sat, Aug 8, 12:03 PM

	Unknown Object (File)
	Sat, Aug 8, 2:19 AM

	Unknown Object (File)
	Fri, Aug 7, 3:09 PM

Subscribers

bmueller_panasas.com

Details

Reviewers

emaste
dteske
allanjude

Commits

rS323508: When doing a non-interactive installation, don't display an interactive

Summary

Don't bother with an interactive prompt for scripted installs; assume the person who wrote the script knew what they were doing, and proceed.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rpokala created this revision.Sep 12 2017, 9:42 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 12 2017, 9:42 PM

Harbormaster completed remote builds in B11530: Diff 32990.Sep 12 2017, 9:42 PM

rpokala edited the summary of this revision. (Show Details)Sep 12 2017, 9:44 PM

rpokala added a subscriber: bmueller_panasas.com.

dteske added a subscriber: dteske.Sep 12 2017, 9:45 PM

dteske added inline comments.

usr.sbin/bsdinstall/partedit/gpart_ops.c
1055–1056 ↗	(On Diff #32990)	"choice = 0;" can be moved above the "if (interactive) {" line to eliminate the need for an "} else {" (improves readability imho)

dteske added a reviewer: dteske.Sep 12 2017, 9:45 PM

Address dteske's comment by unconditionally setting "choice", and overriding it
for the interactive case.

Harbormaster completed remote builds in B11531: Diff 32991.Sep 12 2017, 9:57 PM

rpokala marked an inline comment as done.Sep 12 2017, 9:58 PM

allanjude accepted this revision.Sep 12 2017, 9:59 PM

This revision is now accepted and ready to land.Sep 12 2017, 9:59 PM

dteske accepted this revision.Sep 12 2017, 10:12 PM

Closed by commit rS323508: When doing a non-interactive installation, don't display an interactive (authored by rpokala). · Explain WhySep 12 2017, 10:19 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

usr.sbin/

bsdinstall/

partedit/

19 lines

Diff 32992

head/usr.sbin/bsdinstall/partedit/gpart_ops.c

Loading...