sysutils/py-diffoscope: Update to 86 * Add textproc/diffutils as a dependency PR: 220870 Approved by: koobs (maintainer) Differential_Revision: D12328
- portlint: OK
- testport: OK (log attached)
- maketest: OK (known failures due to upstream incompatibility with FreeBSD)
I added some details (to the TEST PLAN section of the review) of what needs to be tested (portlint, poudriere, make test). Just edit the review and add the results.
In particular, poudriere tests for complete packaging compliance (not just build or install)
For more information on testing, see: https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/testing.html
If you have any questions don't hesitate to ask, and thank you for contributing :)
Thank you for the detailed instructions! It passed the portlint test, however, make test initially failed since it is looking for /usr/local/bin/perl5.24.2, but only /usr/local/bin/perl5.24.1 and /usr/local/bin/perl are available. I made a symlink to work it around (sudo ln -s /usr/local/bin/perl5.24.1 /usr/local/bin/perl5.24.2), but I am not sure what files to look at, and if it is a bug worth reporting.
The log is shown below:
➜ py-diffoscope (D12328) ✔ sudo make test
> Testing for py36-diffoscope-86
> p5-Locale-gettext-1.07 depends on package: perl5>=5.24<5.25 - found
> p5-Locale-gettext-1.07 depends on shared library: libintl.so - found (/usr/local/lib/libintl.so)
> Configuring for p5-Locale-gettext-1.07
env: /usr/local/bin/perl5.24.2: No such file or directory
- Error code 127
make: stopped in /usr/home/guangyuan/freebsd-ports/devel/p5-Locale-gettext
- Error code 1
make: stopped in /usr/home/guangyuan/freebsd-ports/sysutils/py-diffoscope
This may be a perl ports framework issue or bug, as the port dependency is declared and satisfied at the first minor version > 5.24 < 5.25 level, but the framework (configure) target uses an exact build version (5.24.2) level to check for perl. There are some similar (recent, June, July, August) google results for the same error, for mytop, firefox, chromium and other ports.
However, it may have already been fixed, so first: ensure your ports tree is up to date and try again. If you're using quarterly packages, switch to 'latest'
If those dont' work:
Upgrade perl5.24 to the latest version (to 5.24.2) first on the system, then try again.
@mat may be able to shed some more light if the above is incorrect/incomplete or provide additional suggestions.
We do not support having out of sync ports tree vs /usr/local.
You need to upgrade your system to use the latest version of every software in the ports tree your are using for your tests.
Alternatively, you should read 9.5. Poudriere to learn how to use poudriere and never have those kind of issues when testing ports.
make test will successfully run with several (~10) tests failed. This is somewhat expected since Version 84 has test fails as well (see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220870). Will follow up the PR or create a new one for tracking, but that doesn't really affect this update for now IMO.
TEST PLAN is updated.
LGTM, nice work!
Don't forget to remove any underscores from Property_lines: if/when copy/pasting commit log message from the SUMMARY section, otherwise the review wont automatically close on commit
Our standard approach for cross-repo commits (doc committer committing to ports tree, ports committer committing to src tree, etc.) is that one asks for approval from a (non-mentored) committer to the appropriate repo. In this case @koobs is a ports committer in addition to maintainer of the py-diffoscope port, and the acceptance here is suitable for committing the ports change. It's still reasonable for the mentor to provide guidance/advice on this process though.