Page MenuHomeFreeBSD
Differential D12188

Fix LACP with extended media.
ClosedPublic
Actions

Authored by np on Aug 31 2017, 5:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 18, 5:30 AM
Unknown Object (File)
Tue, Apr 16, 2:08 AM
Unknown Object (File)
Thu, Apr 11, 1:47 PM
Unknown Object (File)
Sun, Apr 7, 12:04 PM
Unknown Object (File)
Jan 26 2024, 10:28 AM
Unknown Object (File)
Jan 23 2024, 8:40 PM
Unknown Object (File)
Jan 13 2024, 3:39 AM
Unknown Object (File)
Dec 20 2023, 3:34 AM
View All 29 Files
Subscribers
ae
imp
mjoras

Details

Reviewers
eugen_grosbein.net
mjoras
Group Reviewers
network
Commits
rS330301: MFC r323221:
rS323221: Make LACP based lagg work with interfaces (like 100Gbps and 25Gbps) that
Summary

Make LACP based lagg work with interfaces (like 100Gbps and 25Gbps) that
report extended media types.

lacp_aggregator_bandwidth() uses the media to determine the speed of the
interface and returns 0 for IFM_OTHER without the bits in the extended range.

Reported by: Kevin Bowling @ LLNW
Sponsored by: Chelsio Communications

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

np created this revision.Aug 31 2017, 5:50 PM
Herald added subscribers: ae, imp. · View Herald TranscriptAug 31 2017, 5:50 PM
Harbormaster completed remote builds in B11313: Diff 32553.Aug 31 2017, 5:50 PM
eugen_grosbein.net accepted this revision.Aug 31 2017, 7:57 PM
This revision is now accepted and ready to land.Aug 31 2017, 7:57 PM
mjoras accepted this revision.Aug 31 2017, 8:52 PM
mjoras added a subscriber: mjoras.

When you commit can you be more explicit about why this fixes it with the extended media types? For people not familiar with if_lagg some more specifics in the message would be helpful.

Also unless I'm mistaken it looks like IF_BRIDGE(4) has the same bug. Should we fix that as well?

mjoras added a comment.Aug 31 2017, 9:02 PM
In D12188#252955, @mjoras wrote:

Also unless I'm mistaken it looks like IF_BRIDGE(4) has the same bug. Should we fix that as well?

Upon further inspection, it doesn't actually matter for bridge interfaces.

np edited the summary of this revision. (Show Details)Aug 31 2017, 9:05 PM
In D12188#252955, @mjoras wrote:

When you commit can you be more explicit about why this fixes it with the extended media types? For people not familiar with if_lagg some more specifics in the message would be helpful.

I updated the review summary, which is going to be the commit message.

mjoras added a comment.Aug 31 2017, 9:08 PM
In D12188#252958, @np wrote:
In D12188#252955, @mjoras wrote:

When you commit can you be more explicit about why this fixes it with the extended media types? For people not familiar with if_lagg some more specifics in the message would be helpful.

I updated the review summary, which is going to be the commit message.

Thanks, LGTM!

Closed by commit rS323221: Make LACP based lagg work with interfaces (like 100Gbps and 25Gbps) that (authored by np). · Explain WhySep 6 2017, 2:36 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
net/
6 lines

Diff 32714

View Options

head/sys/net/ieee8023ad_lacp.c

Loading...