Page MenuHomeFreeBSD

Update sigaction(2) to reflect the implemention in src/sys/sys/signal.h
AbandonedPublic

Authored by sevan on Aug 12 2017, 3:20 PM.
Tags
None
Referenced Files
F81917835: D12006.id.diff
Tue, Apr 23, 4:01 AM
Unknown Object (File)
Sat, Apr 6, 3:38 AM
Unknown Object (File)
Dec 20 2023, 12:42 AM
Unknown Object (File)
Aug 29 2023, 5:49 PM
Unknown Object (File)
Jul 9 2023, 8:16 AM
Unknown Object (File)
Jun 6 2023, 3:35 PM
Unknown Object (File)
Apr 18 2023, 7:45 PM
Unknown Object (File)
Apr 7 2023, 4:07 PM
Subscribers

Details

Reviewers
bcr
jilles
Group Reviewers
Src Committers
manpages
Summary

Bug 211365
Konstantin Stroykovskiy <bonkor@gmail.com>

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 11050
Build 11435: arc lint + arc unit

Event Timeline

Gee, You really make me wish I had a src bit to approve this. :-\
I can't help here, sorry.

jilles requested changes to this revision.Aug 12 2017, 5:39 PM
jilles added a subscriber: jilles.

Note the paragraph below starting with "The above declaration of struct sigaction is not literal.". The man page is inconsistent now.

Also, I don't think applications are supposed to use the __sigaction_u, __sa_handler and __sa_sigaction identifiers.

The definition in the man page could be clarified using a C11 anonymous union, but this cannot be used in the implementation, since we do not want to require using recent compilers and standards to compile application code.

This revision now requires changes to proceed.Aug 12 2017, 5:39 PM
In D12006#248864, @bcr wrote:

Gee, You really make me wish I had a src bit to approve this. :-\
I can't help here, sorry.

(unmentored) doc committers have privileges to commit man page changes to src without additional src approval. Why would one think that the situation would be different when approving mentored doc committers for similar purposes?

Right, I sometimes hesitate because I can't grasp the extend of the change and whether what the man page change does reflects the src tree and what is done there.

@jilles best to just revert the commit & leave it as-is?

@jilles best to just revert the commit & leave it as-is?

As far as I can see, nothing was committed so there is nothing to revert.

Perhaps something could be changed to clarify somehow inside the synopsis that sa_handler and sa_sigaction may overlap.

Ah , I got my reviews mixed up. Abandoning.
Thanks for the input :)