Page MenuHomeFreeBSD

Export std::get_new_handler() from libcxxrt.so
ClosedPublic

Authored by arichardson on Aug 8 2017, 3:47 PM.

Details

Summary

When trying to build world for MIPS64 with clang I was getting
linker errors because of a missing reference to std::get_new_handler().
It turns out std::get_new_handler() was not listed in Version.map so it was
marked as a local symbol in libcxxrt.so.

Obtained from: CheriBSD (https://github.com/CTSRD-CHERI/cheribsd/commit/f33ca065031020e307e21bef9a2074e777111f1e)

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

arichardson created this revision.Aug 8 2017, 3:47 PM
emaste added inline comments.Aug 8 2017, 4:40 PM
lib/libcxxrt/Version.map
329 ↗(On Diff #31762)

For consistency with stdlibc++ this should go in GLIBCXX_3.4.20, but I don't really know why this is done.

arichardson updated this revision to Diff 34663.Nov 2 2017, 9:30 AM

Use GLIBCXX_3.4.20

brooks accepted this revision.Nov 2 2017, 12:06 PM

LGTM

This revision is now accepted and ready to land.Nov 2 2017, 12:06 PM
emaste accepted this revision.Nov 2 2017, 1:46 PM
theraven accepted this revision.Nov 2 2017, 2:19 PM
This revision was automatically updated to reflect the committed changes.