Fix clang 3.5.0 warning in isa_defs.h

[dim]

Summary

Fix the following -Werror warning from clang 3.5.0, while building cddl/lib/libctf:

In file included from cddl/contrib/opensolaris/common/ctf/ctf_create.c:31:
In file included from sys/cddl/contrib/opensolaris/uts/common/sys/sysmacros.h:34:
sys/cddl/contrib/opensolaris/uts/common/sys/isa_defs.h:334:9: warning: '_ILP32' macro redefined [-Wmacro-redefined]
#define _ILP32
        ^
<built-in>:26:9: note: previous definition is here
#define _ILP32 1
        ^
1 warning generated.

Test Plan

Compile it with gcc, clang 3.4 and clang 3.5.

[emaste]

Seems reasonable to me.

Is the difference just that older Clang does not warn about defining a built-in macro with the same value? (I.e., _ILP32 is a built-in, in both Clang 3.4.2 and 3.5.)

[dim]

Apparently clang 3.4.1 and 3.4.2 do not define _ILP32, while 3.5.0 defines both _ILP32 and ILP32 internally. It was added here: http://llvm.org/viewvc/llvm-project?view=revision&revision=212931

[emaste]

Oh, interesting. I see that _LP64 and LP64 were already defined in 3.4.x, but not the corresponding 32-bit ones.

[avg]

LGTM

[smh]

[delphij]

LGTM.

[dim]

Closed by commit rS274697 (authored by @dim).