Handle WITH/WITHOUT_PF in libsysdecode

[kp]

Summary

Only filter out the PF ioctls if we're building without pf support.
Until now those were always filtered out, so truss did not show symbolic
names for pf ioctls.

Test Plan

Built with and without WITHOUT_PF set.
Ran truss pfctl -s all with both versions of libsysdecode.so

[jhb]

Looks like glebius@ added the exclusion. I think ideally we'd fix the headers to not result in compile failures during a WITHOUT_PF=yes buildworld then we would be able to leave them in always. The disk filter is no longer needed after pc98 was removed (and it was overly broad as it hid ioctls in <sys/disk.h>) so I'm going to be removing after a tinderbox build finishes.

[kp]

If WITHOUT_PF is set we don't install pf.h (from sys/netpfil/pf), which means the generated file won't compile.
I suppose we could install it, but it's a little odd having pf.h installed if the user explicitly asked not to have pf.

[jhb]

Oh, ok. Shouldn't the includes not be present in the include dir then?

[jhb]

(I'm kicking off some tinderbox builds now to test the idea of just removing the pf filter altogether btw)

[kp]

Ideally, yes, but it looks like the headers from sys/net (pfvar.h and if_pfsync.h) do get installed, so including those files leads to build failures.

[kp]

Update patch after mkioctls was changed.

[jhb]

Thanks!

lib/libsysdecode/mkioctls

22 ↗

(On Diff #31048)

I do feel like 'if [ ... ]; then' is the more common style in the tree (matches how { is used with if in C in style(9))?

[kp]

I've fixed that style remark and commit it. Thanks for the review!