Page MenuHomeFreeBSD

Enable building libc++experimental on all arches with C++11 support
AbandonedPublic

Authored by dim on Jul 7 2017, 11:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 19 2024, 1:45 AM
Unknown Object (File)
Jan 28 2024, 12:02 PM
Unknown Object (File)
Dec 22 2023, 11:25 PM
Unknown Object (File)
Dec 8 2023, 3:10 AM
Unknown Object (File)
May 9 2023, 5:14 PM
Unknown Object (File)
Jan 24 2023, 11:47 AM
Unknown Object (File)
Jan 16 2023, 9:50 PM
Subscribers

Details

Summary

The libc++experimental library was added recently, but one part of it
(std::experimental::filesystem) contains a number of flawed static
assertion tests, which assume time_t is always 64 bit on LP64
systems, and 32 bit otherwise.

Change the preprocessor guards to test for TIME_T_64BIT instead, which
we can then define appropriately for the platform in the Makefile.

Not that for -CURRENT, as of recently, the only arch left with 32 bit
time_t is i386. If this ever gets MFC'd, that would also include 32 bit
PowerPC, IIRC.

Test Plan

I would like somebody who saw errors earlier, on e.g. arm or powerpc,
check if this now builds correctly. :)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Errors
SeverityLocationCodeMessage
Errorlib/libc++experimental/Makefile:NAME1Bad Filename
Unit
No Test Coverage
Build Status
Buildable 10370
Build 10781: arc lint + arc unit

Event Timeline

Abandoning for now, upstream has fixed this in a different way, and I'm going to merge 5.0.0 soon enough anyway.