netfront.c: avoid gcc variably-modified warning
ClosedPublic
Actions

Authored by rlibby on Jun 29 2017, 9:39 PM.

Tags

None

Referenced Files

	F133357215: D11417.diff
	Sat, Oct 25, 4:15 AM

	Unknown Object (File)
	Tue, Oct 21, 8:28 PM

	Unknown Object (File)
	Thu, Oct 2, 2:32 AM

	Unknown Object (File)
	Wed, Oct 1, 1:23 PM

	Unknown Object (File)
	Wed, Oct 1, 4:01 AM

	Unknown Object (File)
	Wed, Oct 1, 12:30 AM

	Unknown Object (File)
	Aug 27 2025, 2:10 AM

	Unknown Object (File)
	Aug 5 2025, 7:42 AM

Subscribers

Details

Reviewers

royger
markj

Commits

rS320517: netfront.c: avoid gcc variably-modified warning

Summary

gcc produces a "variably modified X at file scope" warning for structures that use these size definitions. I think the definitions are actually fine but can be rephrased with the __CONST_RING_SIZE macro more cleanly anyway.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10210
Build 10631: arc lint + arc unit

Event Timeline

rlibby created this revision.Jun 29 2017, 9:39 PM

Harbormaster completed remote builds in B10210: Diff 30242.Jun 29 2017, 9:39 PM

rlibby edited reviewers, added: royger; removed: gibbs, kmacy.Jun 29 2017, 9:44 PM

rlibby added subscribers: kmacy, gibbs.

Thanks, that's indeed better.

This revision is now accepted and ready to land.Jun 30 2017, 3:27 PM

Approved.

Closed by commit rS320517: netfront.c: avoid gcc variably-modified warning (authored by rlibby). · Explain WhyJun 30 2017, 10:14 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

dev/

xen/

netfront/

netfront.c

4 lines

Diff 30242

View Options

sys/dev/xen/netfront/netfront.c

netfront.c: avoid gcc variably-modified warningClosedPublicActions