netfront.c: avoid gcc variably-modified warning
ClosedPublic
Actions

Authored by rlibby on Jun 29 2017, 9:39 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Mar 25, 9:26 AM

	Unknown Object (File)
	Wed, Mar 25, 9:25 AM

	Unknown Object (File)
	Wed, Mar 25, 9:25 AM

	Unknown Object (File)
	Tue, Mar 24, 9:53 AM

	Unknown Object (File)
	Mon, Mar 23, 2:18 AM

	Unknown Object (File)
	Thu, Mar 19, 7:35 PM

	Unknown Object (File)
	Thu, Mar 19, 3:52 PM

	Unknown Object (File)
	Sun, Mar 15, 1:59 AM

Subscribers

Details

Reviewers

royger
markj

Commits

rS320517: netfront.c: avoid gcc variably-modified warning

Summary

gcc produces a "variably modified X at file scope" warning for structures that use these size definitions. I think the definitions are actually fine but can be rephrased with the __CONST_RING_SIZE macro more cleanly anyway.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rlibby created this revision.Jun 29 2017, 9:39 PM

Harbormaster completed remote builds in B10210: Diff 30242.Jun 29 2017, 9:39 PM

rlibby edited reviewers, added: royger; removed: gibbs, kmacy.Jun 29 2017, 9:44 PM

rlibby added subscribers: kmacy, gibbs.

Thanks, that's indeed better.

This revision is now accepted and ready to land.Jun 30 2017, 3:27 PM

Approved.

Closed by commit rS320517: netfront.c: avoid gcc variably-modified warning (authored by rlibby). · Explain WhyJun 30 2017, 10:14 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

xen/

netfront/

netfront.c

4 lines

Diff 30281

View Options

head/sys/dev/xen/netfront/netfront.c

netfront.c: avoid gcc variably-modified warningClosedPublicActions