Reduce code duplication in rpc.lockd.
ClosedPublic
Actions

Authored by delphij on Jun 18 2017, 9:56 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Oct 15, 4:20 AM

	Unknown Object (File)
	Mon, Sep 29, 8:30 PM

	Unknown Object (File)
	Thu, Sep 25, 7:07 PM

	Unknown Object (File)
	Sun, Sep 21, 9:25 AM

	Unknown Object (File)
	Tue, Sep 16, 11:32 PM

	Unknown Object (File)
	Sep 14 2025, 10:26 AM

	Unknown Object (File)
	Sep 14 2025, 10:21 AM

	Unknown Object (File)
	Sep 14 2025, 10:11 AM

View All 91 Files

Subscribers

imp

Details

Reviewers

rmacklem
hrs
cem
alfred
kevlo
rstone

Commits

rS320183: Reduce code duplication in rpc.lockd.

Summary

Reuse create_service code instead of duplicating it in
lookup_addresses for kernel NLM.

As a (good) side effect this also fixed a few issues that were
already fixed in the former but never applied to the latter.

Test Plan

Run rpc.lockd

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

delphij created this revision.Jun 18 2017, 9:56 AM

Herald added a subscriber: imp. · View Herald TranscriptJun 18 2017, 9:56 AM

Harbormaster completed remote builds in B9959: Diff 29773.Jun 18 2017, 9:56 AM

Works fine for me. Tested on amd64.

This revision is now accepted and ready to land.Jun 21 2017, 6:28 AM

Closed by commit rS320183: Reduce code duplication in rpc.lockd. (authored by delphij). · Explain WhyJun 21 2017, 6:34 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

usr.sbin/

rpc.lockd/

lockd.c

271 lines

Diff 29882

View Options

head/usr.sbin/rpc.lockd/lockd.c

Reduce code duplication in rpc.lockd.ClosedPublicActions