limit buffer sizes.
ClosedPublic
Actions

Authored by delphij on May 26 2017, 7:44 AM.

Details

Reviewers

cem
des
emaste
rmacklem
alfred

Commits

rS319369: * limit size of buffers to RPC_MAXDATASIZE

Summary

limit size of buffers to RPC_MAXDATASIZE
don't leak memory
be more picky about bad parameters

From:

https://raw.githubusercontent.com/guidovranken/rpcbomb/master/libtirpc_patch.txt
https://github.com/guidovranken/rpcbomb/blob/master/rpcbind_patch.txt

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

delphij created this revision.May 26 2017, 7:44 AM

Herald added a subscriber: imp. · View Herald TranscriptMay 26 2017, 7:44 AM

Harbormaster completed remote builds in B9499: Diff 28839.May 26 2017, 7:44 AM

cem accepted this revision.May 26 2017, 2:22 PM

This revision is now accepted and ready to land.May 26 2017, 2:22 PM

LGTM

lib/libc/rpc/rpc_generic.c
612–614 ↗	(On Diff #28839)	style(9) for consistency?

style(9) fixes for new code.

This revision now requires review to proceed.May 27 2017, 1:29 AM

Harbormaster completed remote builds in B9519: Diff 28893.May 27 2017, 1:29 AM

delphij added a reviewer: alfred.May 27 2017, 1:29 AM

emaste accepted this revision.May 27 2017, 1:53 AM

This revision is now accepted and ready to land.May 27 2017, 1:53 AM

Closed by commit rS319369: * limit size of buffers to RPC_MAXDATASIZE (authored by delphij). · Explain WhyJun 1 2017, 6:12 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

lib/

libc/

rpc/

rpc_generic.c

8 lines

rpcb_prot.c

17 lines

rpcb_st_xdr.c

9 lines

xdr/

xdr.c

30 lines

sys/

rpc/

rpc_generic.c

8 lines

rpcb_clnt.c

5 lines

rpcb_prot.c

15 lines

xdr/

xdr.c

30 lines

usr.sbin/

rpcbind/

rpcb_svc_com.c

4 lines

Diff 29108

View Options

head/lib/libc/rpc/rpc_generic.c

View Options

head/lib/libc/rpc/rpcb_prot.c

View Options

head/lib/libc/rpc/rpcb_st_xdr.c

View Options

head/lib/libc/xdr/xdr.c

View Options

head/sys/rpc/rpc_generic.c

View Options

head/sys/rpc/rpcb_clnt.c

View Options

head/sys/rpc/rpcb_prot.c

View Options

head/sys/xdr/xdr.c

View Options

head/usr.sbin/rpcbind/rpcb_svc_com.c

limit buffer sizes.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 29108

head/lib/libc/rpc/rpc_generic.c

head/lib/libc/rpc/rpcb_prot.c

head/lib/libc/rpc/rpcb_st_xdr.c

head/lib/libc/xdr/xdr.c

head/sys/rpc/rpc_generic.c

head/sys/rpc/rpcb_clnt.c

head/sys/rpc/rpcb_prot.c

head/sys/xdr/xdr.c

head/usr.sbin/rpcbind/rpcb_svc_com.c

limit buffer sizes.
ClosedPublic
Actions

Revision Contents
Changeset List