Page MenuHomeFreeBSD

Introduce Genesys GL3224 quirks
ClosedPublic

Authored by mw_semihalf.com on May 25 2017, 3:12 PM.

Details

Summary

The Genesys chip is failing when issueing READ_CAP(16) command.
Force a quirk to disable it and use READ_CAP(10) instead.

Also, depending on used firmware, GL3224 can be recognized
either as 'storage device' or 'mass storage class' -
enable both variants in scsi_quirk_table.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mav edited edge metadata.May 25 2017, 5:15 PM

I have no objections about the first part, I saw enough USB devices with broken implementation, but what exactly the second part is about? What problem It causes? From one side MSC specification indeed does not specify REPORT LUNS command, but does it create some problems here that require the quirk?

GL3224 is a dual LUN, but fails to report them properly - the outcome without quirks are errors and undetected devices, connected to it.

mav accepted this revision.May 25 2017, 5:39 PM

OK. I have no objections. Though may be we could workaround REPORT LUNS globally for all USB MSC devices somehow.

This revision is now accepted and ready to land.May 25 2017, 5:39 PM
This revision was automatically updated to reflect the committed changes.