Avoid switching to root twice for saving options

[dim]

Summary

When creating new options for a port, bsd.port.mk switches to root
twice: first for creating the options directory (/var/db/ports/foo_bar),
second for copying the temporary options file to that directory.

Avoid this by using SU_CMD just once, creating the options directory and
copying the temporary options file in one command.

(Some of the commands are now pretty long, but wrapping them to 80
characters makes them rather awkward. Suggestions are greatly
appreciated. :)

[rene]

The patch works when I run 'make config' as root, but I get this output:

> Switching to root credentials to write /var/db/ports/comms_dcf77pi/options

> Returning to user credentials

It works fine as user, but somehow I do not see why, line 4731 seems to suggest that /var/db/ports/foo_bar must exist (true) and (be writable for non-root (false) or not owned by the current user (true)) for the non-root commands to be run.
When run as root, this line evaluates to /var/db/ports/foo_bar exists (true) and (writable for root (true) or not owned by current user (false)) so in that case the "then" part of the if clause should be run, not the "else" part

[mat]

I've been wondering why this is needed, and then, I saw that in my make.conf, I have:

SU_CMD=/usr/local/bin/sudo -E sh -c

[dim]

In D10898#268363, @mat wrote:

I've been wondering why this is needed, and then, I saw that in my make.conf, I have:

SU_CMD=/usr/local/bin/sudo -E sh -c

Indeed, that is almost exactly the same thing I have:

SU_CMD=${LOCALBASE}/bin/sudo -E /bin/sh -c

IIRC this comes from one or other handbook or guide, but I forgot which. :)

In D10898#265281, @rene wrote:

The patch works when I run 'make config' as root, but I get this output:

> Switching to root credentials to write /var/db/ports/comms_dcf77pi/options

> Returning to user credentials

It works fine as user, but somehow I do not see why, line 4731 seems to suggest that /var/db/ports/foo_bar must exist (true) and (be writable for non-root (false) or not owned by the current user (true)) for the non-root commands to be run.
When run as root, this line evaluates to /var/db/ports/foo_bar exists (true) and (writable for root (true) or not owned by current user (false)) so in that case the "then" part of the if clause should be run, not the "else" part

You shouldn't run as root. ;) But joking aside, it might indeed be better if the statement ${MKDIR} $${optionsdir} 2> /dev/null && ${CAT} $${TMPOPTIONSFILE} > ${OPTIONS_FILE}" is not repeated twice, but somehow folded into one.

[mat]

Mk/bsd.port.mk

4731

I don't think [ -e "${optionsdir}" ] is correct, or even needed here. We do not care wether the directory exists at all.

Say you are running as root and it does not exist, you end up running the code through ${SU_CMD} where you really do not need to.