Page MenuHomeFreeBSD

Introduce platform CPU info container for ARM. Use it for ACTLR.
AbandonedPublic

Authored by zbb on May 11 2017, 3:57 PM.

Details

Summary

This change allows for additional, platform-specific quirks
in the CPU configuration based on CPU info.
Add plat_cpuinfo to store any quirks or additional settings
to be applied by the platform code.
Use it to modify default ACTLR set-up if needed.

Submitted by: Zbigniew Bodek <zbb@semihalf.com>
Obtained from: Semihalf
Sponsored by: Stormshield

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 9204
Build 9651: CI src buildJenkins

Event Timeline

zbb created this revision.May 11 2017, 3:57 PM
mmel edited edge metadata.May 14 2017, 6:47 AM

Otherwise, I'm fine with this.

sys/arm/arm/cpuinfo.c
248

Please, follow logic used in this function and use one variable for 'mask' and other for 'set'.

sys/arm/include/cpuinfo.h
129

Only minor nit - plat_cpuinfo doesn't looks like best name - what about:

struct cpuinfo_quirks {
        uint32_t actlr_mask;
        uint32_t actlr_set;
};
zbb abandoned this revision.Jun 16 2017, 2:41 PM

Will use environment variable.