Intel iwm 8265 support

[br]

Summary

based on dragonflybsd commit 0ce37bc4c6e593a32c291a336cded0c296f4f50b, de5b132c392d22d8b31019edfc45586208765554

Test Plan

tested on Lenovo X1 Carbon 2017

UPD:
tested at office and in the airport (key_mgmt is NONE): works fine
tested at home (key_mgmt is WPA-PSK): controller panicked

[adrian]

I'll get to this once I finish updating to the latest dfbsd drop. :)

[dch]

I can't do a code review but I can confirm it works - currently writing this comment using it :-)

intel 8265 https://www.alternate.at/html/product/1305519

iwm0: <Intel(R) Dual Band Wireless AC 8265> mem 0xdc200000-0xdc201fff at device 0.0 on pci2
iwm0: hw rev 0x230, fw ver 22.361476.0, address 00:28:f8:d0:91:52
iwm0: iwm_update_edca: called

wlan0: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500
	ether 00:28:f8:d0:91:52
	inet6 fe80::228:f8ff:fed0:9152%wlan0 prefixlen 64 scopeid 0x2 
	inet 172.16.2.15 netmask 0xffffff00 broadcast 172.16.2.255 
	nd6 options=23<PERFORMNUD,ACCEPT_RTADV,AUTO_LINKLOCAL>
	media: IEEE 802.11 Wireless Ethernet OFDM/54Mbps mode 11g
	status: associated
	ssid skunkwerks channel 6 (2437 MHz 11g) bssid 80:2a:a8:84:e2:a3
	regdomain ETSI country AT authmode WPA2/802.11i privacy ON
	deftxkey UNDEF AES-CCM 2:128-bit txpower 30 bmiss 10 scanvalid 60
	protmode CTS wme roaming MANUAL
	groups: wlan

I'll give you an update in a couple of days using this, let me know if there's any specific info you want.

h/w is a Kabylake Dell XPS13 running drm-next and D10597 patch.

[dch]

So far, it works flawlessly for me in client mode, no issues at all. I've not set up an access point before and I don't have any more hardware to test against it.

[dch]

Bumping to latest freebsd-desktop/drm-next branch I get the following failure:

Building /usr/obj/usr/src/sys/GENERIC/modules/usr/src/sys/modules/iwm/if_iwm.o
Building /usr/obj/usr/src/sys/GENERIC/modules/usr/src/sys/modules/isci/sati_test_unit_ready.o
Building /usr/obj/usr/src/sys/GENERIC/ar9300_stub.o
Building /usr/obj/usr/src/sys/GENERIC/modules/usr/src/sys/modules/isci/sati_unmap.o
/usr/src/sys/dev/iwm/if_iwm.c:5439:8: error: duplicate case value 'IWM_DEBUG_LOG_MSG'
                case IWM_DEBUG_LOG_MSG:
                     ^
/usr/src/sys/dev/iwm/if_iwm.c:5435:8: note: previous case defined here
                case IWM_DEBUG_LOG_MSG:
                     ^
1 error generated.
--- if_iwm.o ---
*** [if_iwm.o] Error code 1

I think this is a conflict with "[iwm] Ignore IWM_DEBUG_LOG_MSG notifications." https://github.com/skunkwerks/freebsd/commit/f5210630304b98d8e16185c4737b9f1d04968488

This diff seems to fix it:

Author: Dave Cottlehuber <[e-mail]>
Date:   Wed Jun 14 04:44:22 2017 +0000

    iwm: fix conflicting diff

diff --git a/sys/dev/iwm/if_iwm.c b/sys/dev/iwm/if_iwm.c
index 9b490b303d6e..619a4b1ea2d0 100644
--- a/sys/dev/iwm/if_iwm.c
+++ b/sys/dev/iwm/if_iwm.c
@@ -5432,9 +5432,6 @@ iwm_handle_rxb(struct iwm_softc *sc, struct mbuf *m)
                 * Firmware versions 21 and 22 generate some DEBUG_LOG_MSG
                 * messages. Just ignore them for now.
                 */
-               case IWM_DEBUG_LOG_MSG:
-                       break;
-
                case IWM_MCAST_FILTER_CMD:
                case IWM_DEBUG_LOG_MSG:
                        break;

[lwhsu]

BTW we already have these in head:

https://svnweb.freebsd.org/changeset/base/r324434
https://svnweb.freebsd.org/changeset/base/r324435

[lwhsu]

Probably it's time for MFC: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220229

[guillaume.duque_live.fr]

In D10597#224615, @dch wrote:

So far, it works flawlessly for me in client mode, no issues at all. I've not set up an access point before and I don't have any more hardware to test against it.

Hi !

Could you explain how you did that ? I'm new to the FreeBSD world, I come from GNU/Linux, and I've got the same issue. My laptop, Xiaomi Notebook Pro only got a wireless card, the intel 8265... I've installed FreeBSD, and I gotta patch it to get internet.

Thanks !

[dch]

In D10597#317774, @guillaume.duque_live.fr wrote:

In D10597#224615, @dch wrote:

So far, it works flawlessly for me in client mode, no issues at all. I've not set up an access point before and I don't have any more hardware to test against it.

Hi !

Could you explain how you did that ? I'm new to the FreeBSD world, I come from GNU/Linux, and I've got the same issue. My laptop, Xiaomi Notebook Pro only got a wireless card, the intel 8265... I've installed FreeBSD, and I gotta patch it to get internet.

Thanks !

Hallo Guilllaume, welcome to FreeBSD :-)

You'll need to run FreeBSD-12.0-current which is the unreleased "latest kernel and world" version to get this device support. This might be a bigger step than what you're ready for right now, https://lists.freebsd.org/pipermail/freebsd-questions/2018-April/281496.html has my comments for another user already in it.

You might want to give trueos.org a quick try to see if your device is supported already there, it is a desktop "spin" of FreeBSD current but still using the same code/drivers already in FreeBSD 12.0-CURRENT, but with a few other differences. It's a good place to get started.

If you have further questions, just continue the conversation on the mailing list, I'll try to answer them there.

A+
Dave

[guillaume.duque_live.fr]

In D10597#317798, @dch wrote:

In D10597#317774, @guillaume.duque_live.fr wrote:

In D10597#224615, @dch wrote:

So far, it works flawlessly for me in client mode, no issues at all. I've not set up an access point before and I don't have any more hardware to test against it.

Hi !

Could you explain how you did that ? I'm new to the FreeBSD world, I come from GNU/Linux, and I've got the same issue. My laptop, Xiaomi Notebook Pro only got a wireless card, the intel 8265... I've installed FreeBSD, and I gotta patch it to get internet.

Thanks !

Hallo Guilllaume, welcome to FreeBSD :-)

You'll need to run FreeBSD-12.0-current which is the unreleased "latest kernel and world" version to get this device support. This might be a bigger step than what you're ready for right now, https://lists.freebsd.org/pipermail/freebsd-questions/2018-April/281496.html has my comments for another user already in it.

You might want to give trueos.org a quick try to see if your device is supported already there, it is a desktop "spin" of FreeBSD current but still using the same code/drivers already in FreeBSD 12.0-CURRENT, but with a few other differences. It's a good place to get started.

If you have further questions, just continue the conversation on the mailing list, I'll try to answer them there.

A+
Dave

Thanks that's cool !

I'm gonna try TrueOS to see how it works there for now.

Thanks !

[guillaume.duque_live.fr]

In D10597#317798, @dch wrote:

In D10597#317774, @guillaume.duque_live.fr wrote:

In D10597#224615, @dch wrote:

So far, it works flawlessly for me in client mode, no issues at all. I've not set up an access point before and I don't have any more hardware to test against it.

Hi !

Could you explain how you did that ? I'm new to the FreeBSD world, I come from GNU/Linux, and I've got the same issue. My laptop, Xiaomi Notebook Pro only got a wireless card, the intel 8265... I've installed FreeBSD, and I gotta patch it to get internet.

Thanks !

Hallo Guilllaume, welcome to FreeBSD :-)

You'll need to run FreeBSD-12.0-current which is the unreleased "latest kernel and world" version to get this device support. This might be a bigger step than what you're ready for right now, https://lists.freebsd.org/pipermail/freebsd-questions/2018-April/281496.html has my comments for another user already in it.

You might want to give trueos.org a quick try to see if your device is supported already there, it is a desktop "spin" of FreeBSD current but still using the same code/drivers already in FreeBSD 12.0-CURRENT, but with a few other differences. It's a good place to get started.

If you have further questions, just continue the conversation on the mailing list, I'll try to answer them there.

A+
Dave

Ok so, I've installed TrueOS, the last version, and my Wireless card isn't detected yet... Same for my Touchpad. Sadly

[koobs]

man iwn shows the 8265 is now supported:

Intel Dual Band Wireless AC 8265

Can this be closed now?