Paths

Table of Contentst

Differential D10344

Include RISC-V to universe
ClosedPublic
Actions

Authored by br on Apr 10 2017, 3:02 PM.

Tags

None

Referenced Files

	F133619851: D10344.diff
	Mon, Oct 27, 1:58 AM

	Unknown Object (File)
	Sun, Oct 26, 6:18 AM

	Unknown Object (File)
	Sat, Oct 18, 11:23 AM

	Unknown Object (File)
	Sat, Oct 18, 1:10 AM

	Unknown Object (File)
	Mon, Oct 13, 6:40 AM

	Unknown Object (File)
	Tue, Oct 7, 5:43 AM

	Unknown Object (File)
	Wed, Oct 1, 8:11 AM

	Unknown Object (File)
	Mon, Sep 29, 3:38 PM

Subscribers

None

Details

Reviewers

andrew
jhb
emaste
imp

Commits

rS316730: Include RISC-V target to universe build.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

br created this revision.Apr 10 2017, 3:02 PM

emaste added inline comments.Apr 10 2017, 3:21 PM

Makefile
434	I wonder if we should check for `/usr/local/share/toolchains/riscv64-gcc.mk` instead? Even though I suspect `riscv64-gcc` depends on `riscv64-binutils`, we still require `riscv64-xtoolchain-gcc` to be installed for `CROSS_TOOLCHAIN=riscv64-gcc` to work

check for /usr/local/share/toolchains/riscv64-gcc.mk

br marked an inline comment as done.Apr 10 2017, 3:26 PM

br added inline comments.

Makefile
434	Agree!

emaste added a reviewer: imp.Apr 10 2017, 3:26 PM

br marked an inline comment as done.Apr 10 2017, 3:29 PM

jhb added inline comments.Apr 10 2017, 5:47 PM

Makefile
426	riscv64sf?
431	Will need MARK_PARAMS_riscv64sf?= as well. Possibly it should be 'MAKE_PARAMS_<target>' instead as otherwise if we require an external GCC for MIPS it would be clumsy to list 9 identical MAKE_PARAMS_mips<foo>' vs a single MAKE_PARAMS_mips.

emaste added inline comments.Apr 10 2017, 5:54 PM

Makefile
431	I think that's fair - if we come to a situation where we need different $target_arch-specific params we can introduce them then.

make_params is now based on TARGET not TARGET_ARCH

This looks good to me, thanks.
FYI clusteradm@ has installed the toolchain packages on the universe*.freebsd.org machines.

This revision is now accepted and ready to land.Apr 11 2017, 8:35 PM

Closed by commit rS316730: Include RISC-V target to universe build. (authored by br). · Explain WhyApr 12 2017, 10:45 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

16 lines

Diff 27301

Makefile

Loading...