Page MenuHomeFreeBSD

Include RISC-V to universe
ClosedPublic

Authored by br on Apr 10 2017, 3:02 PM.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Makefile
434 ↗(On Diff #27298)

I wonder if we should check for /usr/local/share/toolchains/riscv64-gcc.mk instead? Even though I suspect riscv64-gcc depends on riscv64-binutils, we still require riscv64-xtoolchain-gcc to be installed for CROSS_TOOLCHAIN=riscv64-gcc to work

check for /usr/local/share/toolchains/riscv64-gcc.mk

br marked an inline comment as done.Apr 10 2017, 3:26 PM
br added inline comments.
Makefile
434 ↗(On Diff #27298)

Agree!

br marked an inline comment as done.Apr 10 2017, 3:29 PM
Makefile
426 ↗(On Diff #27301)

riscv64sf?

431 ↗(On Diff #27301)

Will need MARK_PARAMS_riscv64sf?= as well.

Possibly it should be 'MAKE_PARAMS_<target>' instead as otherwise if we require an external GCC for MIPS it would be clumsy to list 9 identical MAKE_PARAMS_mips<foo>' vs a single MAKE_PARAMS_mips.

Makefile
431 ↗(On Diff #27301)

I think that's fair - if we come to a situation where we need different $target_arch-specific params we can introduce them then.

make_params is now based on TARGET not TARGET_ARCH

This looks good to me, thanks.
FYI clusteradm@ has installed the toolchain packages on the universe*.freebsd.org machines.

This revision is now accepted and ready to land.Apr 11 2017, 8:35 PM
This revision was automatically updated to reflect the committed changes.