Details
Details
- Reviewers
andrew jhb emaste imp - Commits
- rS316730: Include RISC-V target to universe build.
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| Makefile | ||
|---|---|---|
| 434 ↗ | (On Diff #27298) | I wonder if we should check for /usr/local/share/toolchains/riscv64-gcc.mk instead? Even though I suspect riscv64-gcc depends on riscv64-binutils, we still require riscv64-xtoolchain-gcc to be installed for CROSS_TOOLCHAIN=riscv64-gcc to work |
| Makefile | ||
|---|---|---|
| 434 ↗ | (On Diff #27298) | Agree! |
| Makefile | ||
|---|---|---|
| 426 ↗ | (On Diff #27301) | riscv64sf? |
| 431 ↗ | (On Diff #27301) | Will need MARK_PARAMS_riscv64sf?= as well. Possibly it should be 'MAKE_PARAMS_<target>' instead as otherwise if we require an external GCC for MIPS it would be clumsy to list 9 identical MAKE_PARAMS_mips<foo>' vs a single MAKE_PARAMS_mips. |
| Makefile | ||
|---|---|---|
| 431 ↗ | (On Diff #27301) | I think that's fair - if we come to a situation where we need different $target_arch-specific params we can introduce them then. |
Comment Actions
This looks good to me, thanks.
FYI clusteradm@ has installed the toolchain packages on the universe*.freebsd.org machines.