Create a machine/metadata.h for RISC-V
ClosedPublic
Actions

Authored by allanjude on Apr 3 2017, 12:55 AM.

Details

Reviewers

emaste
br
lwhsu
imp

Summary

sys/crypto/crypto.c includes machine/metadata.h and RISC-V is the only platform that does not have one.
Add a blank one.

This resolves the build error caught by Jenkins:
https://ci.freebsd.org/job/FreeBSD-head-riscv64-build/1167/console

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8445
Build 8741: CI src build	Jenkins
Build 8740: arc lint + arc unit

Event Timeline

allanjude created this revision.Apr 3 2017, 12:55 AM

allanjude edited the summary of this revision. (Show Details)Apr 3 2017, 12:55 AM

Why does sys/crypto/crypto.c include this at all?

The file itself is fine, but I wonder why crypto.c needs it...

This revision is now accepted and ready to land.Apr 3 2017, 1:01 AM

In D10239#211723, @imp wrote:

Why does sys/crypto/crypto.c include this at all?

The file itself is fine, but I wonder why crypto.c needs it...

Good point. I think one of the #defines used to be in that file, but was moved. Let me try a build without the #include

Harbormaster completed remote builds in B8445: Diff 26940.Apr 3 2017, 1:33 AM

br accepted this revision.Apr 3 2017, 8:01 PM

This build problem was resolved by removing metadata.h from sys/opencrypto/crypto.c in rS316483

Is there still interest in creating this empty file?

allanjude closed this revision.Jan 27 2018, 10:47 PM

Revision Contents
Changeset List

Path

Size

sys/

riscv/

include/

metadata.h

9 lines

Diff 26940

View Options

sys/riscv/include/metadata.h

Create a machine/metadata.h for RISC-VClosedPublicActions