Page MenuHomeFreeBSD
Differential D10239

Create a machine/metadata.h for RISC-V
ClosedPublic
Actions

Authored by allanjude on Apr 3 2017, 12:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 22 2023, 9:15 PM
Unknown Object (File)
Nov 10 2023, 6:42 AM
Unknown Object (File)
Sep 9 2023, 4:04 AM
Unknown Object (File)
Sep 6 2023, 5:57 AM
Unknown Object (File)
Dec 22 2022, 11:59 AM
Unknown Object (File)
Nov 28 2022, 6:15 AM
Subscribers
None

Details

Reviewers
emaste
br
lwhsu
imp
Summary

sys/crypto/crypto.c includes machine/metadata.h and RISC-V is the only platform that does not have one.
Add a blank one.

This resolves the build error caught by Jenkins:
https://ci.freebsd.org/job/FreeBSD-head-riscv64-build/1167/console

Diff Detail

Event Timeline

allanjude created this revision.Apr 3 2017, 12:55 AM
allanjude edited the summary of this revision. (Show Details)Apr 3 2017, 12:55 AM
imp accepted this revision.Apr 3 2017, 1:01 AM

Why does sys/crypto/crypto.c include this at all?

The file itself is fine, but I wonder why crypto.c needs it...

This revision is now accepted and ready to land.Apr 3 2017, 1:01 AM
allanjude added a comment.Apr 3 2017, 1:26 AM
In D10239#211723, @imp wrote:

Why does sys/crypto/crypto.c include this at all?

The file itself is fine, but I wonder why crypto.c needs it...

Good point. I think one of the #defines used to be in that file, but was moved. Let me try a build without the #include

Harbormaster completed remote builds in B8445: Diff 26940.Apr 3 2017, 1:33 AM
br accepted this revision.Apr 3 2017, 8:01 PM
allanjude added a comment.Apr 4 2017, 4:01 AM

This build problem was resolved by removing metadata.h from sys/opencrypto/crypto.c in rS316483

Is there still interest in creating this empty file?

allanjude closed this revision.Jan 27 2018, 10:47 PM

Revision Contents
Changeset List

PathSize
sys/
riscv/
include/
9 lines

Diff 26940

View Options

sys/riscv/include/metadata.h

Loading...