Generate a default TESTSDIR
AbandonedPublic
Actions

Authored by ngie on Oct 28 2014, 11:33 PM.

Details

Reviewers

bapt
jmmv
imp
bdrewery

Summary

Generate a default TESTSDIR while still providing the ability to overwrite it

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 695
Build 695: arc lint + arc unit

Event Timeline

bapt updated this revision to Diff 2144.Oct 28 2014, 11:33 PM

bapt retitled this revision from to Generate a default TESTSDIR.

bapt updated this object.

bapt edited the test plan for this revision. (Show Details)

bapt added reviewers: imp, ngie, jmmv.

Herald added a reviewer: bdrewery. · View Herald TranscriptOct 28 2014, 11:33 PM

I disagree with this because it will break if bsd.test.mk is not in share/mk , and it's trying to resolve a bigger problem in the build system.

We need SRCTOP (and other relevant variables) added to FreeBSD (sjg@ has it in the bmake branch). It needs to be used here and elsewhere.

This revision now requires changes to proceed.Oct 28 2014, 11:42 PM

This is fine.

SRCTOP is a much bigger kettle of fish, and shouldn't block this fix.

This is misplaced. TESTSDIR is defined in suite.test.mk, so the change has to be made there.

I don't object to having a sane default for TESTSDIR, though the syntax to make this happen in make hurts my eyes. Actually, I don't even understand what this is intending to compute, and a few local tests show results that don't make sense to me. Could you explain and update the change description accordingly? "Generate a default TESTSDIR" is not very descriptive...

Move definition to suite.test.mk and try to right an understandable description

emaste added a subscriber: emaste.Oct 29 2014, 1:45 PM

emaste added inline comments.

share/mk/suite.test.mk
12–13 ↗	(On Diff #2147)	One of these seems more natural to me: It is derived from TESTSBASE and the relative path to the Makefile. It is derived from TESTSBASE and the relative directory containing the Makefile.

OK, now I understand the value of the new setting.

share/mk/suite.test.mk
12–13 ↗	(On Diff #2147)	Indeed. And make that a complete sentence: The default value of TESTSDIR is TESTSBASE plus the relative path to the directory containing the Makefile.

This revision now requires changes to proceed.Oct 30 2014, 4:36 PM

ngie requested changes to this revision.May 23 2015, 4:50 AM

ngie edited edge metadata.

ngie added inline comments.

share/mk/suite.test.mk
14 ↗	(On Diff #2147)	This unfortunately won't work in all cases (I know because I ran into one of these cases recently at $work). Sometimes the path to suite.test.mk will be relative (e.g. when computed from share/mk), which will make TESTSDIR -> ${TESTSBASE}/. :(... Again, we need SRCTOP in order to determine this information properly...