HomeFreeBSD

Fix a read past the end of a buffer in fsck.

Description

Fix a read past the end of a buffer in fsck.

To minimize the time spent scanning all of the directories in pass 2
(Check Pathnames), fsck uses a search order based on the location
of their first block. Zero length directories have no first block,
so the array being used to hold the block numbers of directory
inodes was of zero length. Thus a lookup was done past the end of
the array getting at best a random value and at worst a segment
fault. For zero length directories, this change allocates a one
element block array and initializes it to zero. The effect is that
all zero length directories are handled first in pass 2.

Reviewed by: brooks
Differential Revision: https://reviews.freebsd.org/D14163

Details

Provenance
mckusickAuthored on
Reviewer
brooks
Differential Revision
D14163: Fix a read past the end of a buffer in fsck.
Parents
rS329748: lualoader: Drop password length restrictions
Branches
Unknown
Tags
Unknown