Fix a read past the end of a buffer in fsck.
ClosedPublic
Actions

Authored by mckusick on Feb 2 2018, 1:58 AM.

Details

Reviewers

brooks
andrew

Commits

rS329749: Fix a read past the end of a buffer in fsck.

Summary

We normally use the first byte of the first block, but if there are no
blocks this results in reading beyond the allocated structure. In this
case sort on the number of blocks.

Submitted by: andrew
Sponsored by: DARPA, AFRL

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks created this revision.Feb 2 2018, 1:58 AM

I concur with the problem, but differ on the solution. When I tried to upload my proposed change it created a whole new report https://reviews.freebsd.org/D14177. How do I just attach a new diff here?

This revision now requires changes to proceed.Feb 2 2018, 9:33 PM

You can use: arc diff --update D14163. It may require you to commandeer the this review in the UI (which is fine by me).

I agree with the problem, but propose this new diff as the correct solution.

brooks added a reviewer: andrew.Feb 2 2018, 10:31 PM

If I read this correctly, you're always allocating one block now? That seems fine to me.

This revision is now accepted and ready to land.Feb 8 2018, 8:14 PM

In response to brooks. You are correct that this always allocates one block and initialises it to zero. Thus all zero-length directories will sort to the front of the list so that they will all be reported in a block.

Closed by commit rS329749: Fix a read past the end of a buffer in fsck. (authored by mckusick). · Explain WhyFeb 21 2018, 8:32 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptFeb 21 2018, 8:32 PM