I can't spot anything wrong, so

In D39303#1064275, @vishwin wrote:

No, Herald (phab) added it automatically. This has already been exp-ran by both portmgr and myself with no problems. I'm basically acting as Python here but leaving this open for a bit to collect feedback on the CHANGES wording.

Are you waiting for portmgr's approval ?
This file is maintained by python@, so, all you need is an exp-run to make sure everything is fine.

The change is wrong, the code is correct. See sh(1):

I have not needed WITH_DEBUG for a while, thanks.

Something like this

In D46059#1053621, @michaelo wrote:

Anyone else, any objections?

We probably need a message on each list asking to keep it in sync with the two other.

Assuming you tested this, and you probably know better than me what this actually does 😇

make -C dns/bind918 -V USE_PERL5 WITH_DEBUG=yes WITHOUT_DEBUG_PORTS=dns/bind918

Results in "build".
This means that the port still believes that the "debug" feature is enabled, while it is actually disabled by the second knob.

This was reverted.

This was not approved, please revert the commit.

If it works...