the idea was to not mess with internal connection state tracking. l2cap module tracks connection state as well. raw sockets primary use case is hcidump. can you please explain why using l2cap socket is not good enough?

looks good, but i have some reservations about adding device specific code to ng_ubt(4)

i think it looks good. i still question the whole idea of querying and putting remote device name in the configuration file, but, ultimately, this is not a hill I want to die on :)

this looks great. my only comments are related to newly added "name" option / parameter. i can not seem to understand its purpose.

depending on the device, the radio may be on the moment you apply power and internal firmware is booted.

I see. Further experimentation has confirmed this. The device seems to persist the "local name" configured by /etc/rc.d/bluetooth in some NVRAM because it survives reboots. That's unfortunate.

In D12831#267334, @cem wrote:

Unfortunately, it isn't clear to me how we can actually prevent devd from loading ng_ubt. devd/usb.conf is autogenerated from the USB devids supported by modules.

please see my comments above. thanks!

can you please add boundary checks? thanks!

thank you for your work!

please see comments. otherwise looks good on first read. thank you for your work!

looks believable

i think it looks fine. i, personally, would try to avoid using "odd" c syntax, i.e. comma and prefix in/decrement where there is no good reason for it. i would also sprinkle some comments explaining where "magic" numbers came from. of course author of the original code should get the credit too. otherwise it looks good. thank you for your work.

sorry, this

just curious why watchdogd_sig_stop rc.conf knob is not working for you.

looks fine

i'm accepting this assuming that possible build breakage related to L2CAP_SOCKET_CHECKED is going to verified. thank you for your work!

couple of minor nits. please see inline. my main concern is to make sure #warning on sockaddr_l2cap is not going to break the build. please assume that L2CAP_SOCKET_CHECKED is likely to not be set. otherwise looks fine.

i don't think its worth worrying about. HID_USAGE is basically

looks fine to me.

please see minor inline comment. thank you for your work!

it looks mostly good to me. a few minor nit picks, and, two somewhat bigger issues

more inline comments