In D53313#1219992, @guest-jsollvander wrote:

In D53313#1219500, @brd wrote:

This looks good to me. Did you run the tests?

I only ran the testsuite in /usr/tests/sys/geom/class and all of those tests came back OK.

This looks good to me. Did you run the tests?

ping?

Is this the right way to do this? I am not familiar with the .po files..

@guest-jsollvander Thanks for doing this!

Fix typos as well since they are part of the original commit.

Address feedback from kevans

In D53180#1215263, @brd wrote:

In D53180#1215259, @guest-jsollvander wrote:

We should add the same check to status_one_geom() as well

OK, added.. Do you know which command would call through this function to verify this?

In D53180#1215259, @guest-jsollvander wrote:

We should add the same check to status_one_geom() as well

Update status_one_geom() too

In D53178#1214927, @guest-svmhdvn wrote:

I think this commit is missing an addition to BSD.tests.dist because I get an error during make installworld. I've posted a quick github PR here, could you review and merge if it's correct? https://github.com/freebsd/freebsd-src/pull/1877

Fix check if the provider is NULL

before:

          Name  Status  Components
  gpt/efiboot0     N/A  N/A
msdosfs/EFISYS     N/A  N/A
  gpt/gptboot0     N/A  N/A
  gpt/efiboot1     N/A  N/A
  gpt/gptboot1     N/A  N/A

Thanks!

Thanks for the feedback

Address feedback

I build an image populated with another custom repo and this makes it easier. It allows for just dropping the config and repo into /usr/freebsd-packages next to the base repo.

Address feedback from kp

Thanks!

Done, thanks! Probably should look at all the driver man pages if that is the case.

@ziaee Thanks for taking the time to review!

Address feedback from ziaee

Bump Dd

Prior to this change on aarch64 we have:

New approach to Azure padding

Will MFC to stable/14 and stable/15

squash

Bump Dd

Thanks, I think also s/exists/exist/.. right?

I am not sure that is correct.. On my system the only thing in /var/cron is the tabs directory and my normal user can use crontab(1).

In D45569#1039673, @theraven wrote:

Why not change the text of the question to ‘are you dual booting Windows on this computer?’

Address feedback

See the newer patch in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=266680