Details
- Reviewers
ifreund_freebsdfoundation.org ivy - Group Reviewers
pkgbase Installer
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 67760 Build 64643: arc lint + arc unit
Event Timeline
What is the goal of this change? Do you want to make it possible for the user to set a custom BSDINSTALL_PKG_REPOS_DIR without requiring them to name their repository FreeBSD-base? I think it would be more robust to add a BSDINSTALL_BASE_REPO_NAME environment variable instead to support that use-case.
Restricting the pkg commands to a single repository seems more robust to me and I don't see a reason to regress that.
i can see two use cases for this:
- a repo built from src doesn't have pkg(8), but we can get it from the ports repository
- the repository might not be called FreeBSD-base
but i don't believe this is the right fix for either issue. in the first case, i'd be okay with a flag like --all-repos to optionally disable the repo restriction. for the second, as Isaac says, a way to set the repo name.
involving ports by default in bsdinstall is just too dangerous, pkg(8) can still sometimes do strange things.