Page MenuHomeFreeBSD

bsdinstall: separate out dist selection in prep for pkgbase support
Needs RevisionPublic

Authored by brd on Feb 5 2024, 10:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 26, 3:18 AM
Unknown Object (File)
Wed, Apr 17, 6:07 PM
Unknown Object (File)
Mar 6 2024, 11:44 PM
Unknown Object (File)
Feb 14 2024, 4:29 AM
Unknown Object (File)
Feb 10 2024, 3:04 AM
Unknown Object (File)
Feb 9 2024, 1:35 AM
Subscribers

Details

Reviewers
asiciliano
jrtc27
Summary

No functional change intended.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 55817
Build 52706: arc lint + arc unit

Event Timeline

brd requested review of this revision.Feb 5 2024, 10:38 PM
jrtc27 requested changes to this revision.Feb 5 2024, 10:57 PM

I've tried to give this a more thorough review and found some issues. Please test it more thoroughly for the various different cases that arise.

usr.sbin/bsdinstall/scripts/Makefile
22

Needs a corresponding OptionalObsoleteFiles.inc entry

usr.sbin/bsdinstall/scripts/auto
67

I won't object to this, but I do feel it's a bit odd to introduce this variable when =n doesn't work. Would it not be better to introduce this at the same time as you add the actual functionality for the =n case?

usr.sbin/bsdinstall/scripts/selectdists
48–53

I believe you still need this dance around it (and FD 3 isn't hooked up to anything here AFAICT)?

70

You can't do this here, it needs to be done up in auto as it checks this variable to know whether to skip netconfig. Otherwise the information is lost the moment selectdists exits.

This revision now requires changes to proceed.Feb 5 2024, 10:57 PM