In D32993#746038, @rmacklem wrote:It now looks good to me.
Do you have a src commit bit?
If not, I can commit it with "Submitted by: yocalebo_gmail.com".
Thanks for the patch, rick
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Nov 17 2021
Nov 17 2021
yocalebo_gmail.com added a comment to D32993: Fix mountd parsing of user/group info in /etc/exports.
yocalebo_gmail.com added a comment to D32993: Fix mountd parsing of user/group info in /etc/exports.
In D32993#745850, @rmacklem wrote:With the one additional change I just commented inline,
I think that will do it.
(Isn't it fun to work with decades old code and still maintain
all the semantics it carries around. Personally, I live in fear
of mountd bugs because the code can be such a beast to
work with.;-)
yocalebo_gmail.com updated the diff for D32993: Fix mountd parsing of user/group info in /etc/exports.
Nov 16 2021
Nov 16 2021
yocalebo_gmail.com updated the diff for D32993: Fix mountd parsing of user/group info in /etc/exports.
yocalebo_gmail.com added a comment to D32993: Fix mountd parsing of user/group info in /etc/exports.
Okay, I've tried to fix the style to be consistent with what freeBSD expects. I've removed the call to cr->cr_uid = atoi(name) because it's a no-op and could never be reached with or without my logic changes. Lastly, I've ensured that if strsep_quote returns NULL that we account for that so we don't crash by passing a NULL value to the various getpw* or getgr calls.
yocalebo_gmail.com updated the diff for D32993: Fix mountd parsing of user/group info in /etc/exports.
Nov 15 2021
Nov 15 2021
yocalebo_gmail.com added inline comments to D32993: Fix mountd parsing of user/group info in /etc/exports.
yocalebo_gmail.com added inline comments to D32993: Fix mountd parsing of user/group info in /etc/exports.
yocalebo_gmail.com added inline comments to D32993: Fix mountd parsing of user/group info in /etc/exports.
yocalebo_gmail.com updated the diff for D32993: Fix mountd parsing of user/group info in /etc/exports.
Uploading new diff addressing Rick Macklem's review.
yocalebo_gmail.com requested review of D32993: Fix mountd parsing of user/group info in /etc/exports.
Mar 24 2021
Mar 24 2021
In D18958#658726, @freqlabs wrote:This is still needed but the code has changed so the patch must be adapted.
Jan 25 2019
Jan 25 2019
I don't believe it will need a man page change because the dump_lockstate function already prints a blank for this column when a call back address isn't found.