Page MenuHomeFreeBSD

yocalebo_gmail.com (Caleb)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 25 2019, 4:06 PM (273 w, 5 d)

Recent Activity

Nov 17 2021

yocalebo_gmail.com added a comment to D32993: Fix mountd parsing of user/group info in /etc/exports.

It now looks good to me.

Do you have a src commit bit?

If not, I can commit it with "Submitted by: yocalebo_gmail.com".

Thanks for the patch, rick

Nov 17 2021, 5:42 PM
yocalebo_gmail.com added a comment to D32993: Fix mountd parsing of user/group info in /etc/exports.

With the one additional change I just commented inline,
I think that will do it.
(Isn't it fun to work with decades old code and still maintain
all the semantics it carries around. Personally, I live in fear
of mountd bugs because the code can be such a beast to
work with.;-)

Nov 17 2021, 2:22 PM
yocalebo_gmail.com updated the diff for D32993: Fix mountd parsing of user/group info in /etc/exports.
Nov 17 2021, 2:18 PM

Nov 16 2021

yocalebo_gmail.com updated the diff for D32993: Fix mountd parsing of user/group info in /etc/exports.
Nov 16 2021, 7:33 PM
yocalebo_gmail.com added a comment to D32993: Fix mountd parsing of user/group info in /etc/exports.

Okay, I've tried to fix the style to be consistent with what freeBSD expects. I've removed the call to cr->cr_uid = atoi(name) because it's a no-op and could never be reached with or without my logic changes. Lastly, I've ensured that if strsep_quote returns NULL that we account for that so we don't crash by passing a NULL value to the various getpw* or getgr calls.

Nov 16 2021, 12:51 PM
yocalebo_gmail.com updated the diff for D32993: Fix mountd parsing of user/group info in /etc/exports.
Nov 16 2021, 12:47 PM

Nov 15 2021

yocalebo_gmail.com added inline comments to D32993: Fix mountd parsing of user/group info in /etc/exports.
Nov 15 2021, 9:04 PM
yocalebo_gmail.com added inline comments to D32993: Fix mountd parsing of user/group info in /etc/exports.
Nov 15 2021, 8:42 PM
yocalebo_gmail.com added inline comments to D32993: Fix mountd parsing of user/group info in /etc/exports.
Nov 15 2021, 8:38 PM
yocalebo_gmail.com updated the diff for D32993: Fix mountd parsing of user/group info in /etc/exports.

Uploading new diff addressing Rick Macklem's review.

Nov 15 2021, 7:24 PM
yocalebo_gmail.com requested review of D32993: Fix mountd parsing of user/group info in /etc/exports.
Nov 15 2021, 2:34 PM

Mar 24 2021

yocalebo_gmail.com added inline comments to D18958: align nfsdumpstate column output.
Mar 24 2021, 8:28 PM
yocalebo_gmail.com updated the diff for D18958: align nfsdumpstate column output.
Mar 24 2021, 8:26 PM
yocalebo_gmail.com updated the summary of D18958: align nfsdumpstate column output.
Mar 24 2021, 6:57 PM
yocalebo_gmail.com updated the summary of D29415: fix lockd daemon().
Mar 24 2021, 6:57 PM
yocalebo_gmail.com added a comment to D18958: align nfsdumpstate column output.

This is still needed but the code has changed so the patch must be adapted.

Mar 24 2021, 6:56 PM
yocalebo_gmail.com updated the diff for D18958: align nfsdumpstate column output.
Mar 24 2021, 6:54 PM
yocalebo_gmail.com requested review of D29415: fix lockd daemon().
Mar 24 2021, 6:40 PM

Jan 25 2019

yocalebo_gmail.com added a comment to D18958: align nfsdumpstate column output.

I don't believe it will need a man page change because the dump_lockstate function already prints a blank for this column when a call back address isn't found.

Jan 25 2019, 5:38 PM
yocalebo_gmail.com created D18958: align nfsdumpstate column output.
Jan 25 2019, 5:30 PM