Page MenuHomeFreeBSD
Feed Advanced Search

Jul 28 2021

cgull_glup.org accepted D31328: loader: support.4th resets the read buffer incorrectly.

LGTM-- though I don't understand exactly what the revisions are based on (your staging repo?) they all look good.

Jul 28 2021, 5:48 PM
cgull_glup.org requested changes to D31328: loader: support.4th resets the read buffer incorrectly.

The end result of this diff is correct, but

  • Phabricator says it's based on a dead SVN repo, which is out of date on this file
  • simultaneously, the old state of the file seems to be that of the bad Git commit rather than the original code at 37053c21~ or the revert at 320e5d7d
Jul 28 2021, 3:31 PM
cgull_glup.org added a comment to R10:37053c21e9d9: loader: support.4th resets the read buffer incorrectly.

LGTM...

Jul 28 2021, 3:27 AM

Jul 16 2021

cgull_glup.org added a comment to R10:37053c21e9d9: loader: support.4th resets the read buffer incorrectly.

LGTM...

Jul 16 2021, 7:07 PM

Mar 9 2018

cgull_glup.org added inline comments to D14608: Add an option to ctime and friends to track /etc/localtime..
Mar 9 2018, 7:49 PM