cryptosoft: Stop single-threading requests within a session.
ClosedPublic
Actions

Authored by jhb on Dec 7 2021, 12:37 AM.

Details

Reviewers

markj
mjg

Commits

rGdc475c9bee02: cryptosoft: Stop single-threading requests within a session.

Summary

All of the request handlers no longer modify session state, so remove
the mutex limiting operations to one per session. In addition, change
the pointer to the session state passed to process callbacks to const.

Suggested by: mjg
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Dec 7 2021, 12:37 AM

Herald added subscribers: jmg, imp. · View Herald TranscriptDec 7 2021, 12:37 AM

jhb requested review of this revision.Dec 7 2021, 12:37 AM

Harbormaster completed remote builds in B43208: Diff 99631.Dec 7 2021, 12:37 AM

jhb added a parent revision: D33316: cryptosoft: Fully support per-operation keys for auth algorithms..Dec 7 2021, 12:37 AM

markj accepted this revision.Dec 7 2021, 1:18 AM

markj added inline comments.

sys/opencrypto/cryptosoft.c
79	No need to break the line, I think.
910	I think this can stay as one line.

This revision is now accepted and ready to land.Dec 7 2021, 1:18 AM

jhb added inline comments.Dec 7 2021, 7:35 PM

sys/opencrypto/cryptosoft.c
79	I think it crossed 80 cols in my editor, but I'll double check.

Thank you!

Is this mfcable to stable/12 by any chance?

In D33317#754176, @mjg wrote:

Thank you!

Is this mfcable to stable/12 by any chance?

Hmmm, I can maybe see about merging to 13. OCF in 12 is quite a bit different. It could perhaps be reimplemented there, but there might be quite a few conflicts.

In that case I would not bother.

jhb marked 2 inline comments as done.Dec 9 2021, 7:28 PM

Closed by commit rGdc475c9bee02: cryptosoft: Stop single-threading requests within a session. (authored by jhb). · Explain WhyDec 9 2021, 8:19 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGdc475c9bee02: cryptosoft: Stop single-threading requests within a session..