Page MenuHomeFreeBSD

graphics/waffle: Update to 1.5.2
ClosedPublic

Authored by dumbbell on Oct 31 2015, 4:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 4, 4:53 AM
Unknown Object (File)
Mon, Mar 4, 4:53 AM
Unknown Object (File)
Mon, Mar 4, 4:53 AM
Unknown Object (File)
Mon, Mar 4, 4:53 AM
Unknown Object (File)
Mon, Mar 4, 4:53 AM
Unknown Object (File)
Sun, Mar 3, 2:29 AM
Unknown Object (File)
Feb 26 2024, 8:44 PM
Unknown Object (File)
Feb 4 2024, 6:02 PM
Subscribers

Details

Summary

Beside the update, explicitely enable the x11_egl platform.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 1043
Build 1046: arc lint + arc unit

Event Timeline

dumbbell retitled this revision from to graphics/waffle: Update to 1.5.2.
dumbbell updated this object.
dumbbell edited the test plan for this revision. (Show Details)
dumbbell added reviewers: kwm, zeising.

Should be fine overall, but has a number of minor style bugs (reported as inline comments).

graphics/waffle/Makefile
15–16

Options-related knobs are typically expected to be found near the very end of other knobs (right before targets section starts).

17

Why these USE_* knobs are separated from the USES and USE_LDCONFIG above?

17–18

Is LIBS (vs. LDFLAGS) really correct here? If not, you might consider using USES=localbase instead.

19–22

These two successive += statements are usually done as one. In this case it looks like it would not even cause the linewrapping.

26–27

I think this target is superfluous (i.e., stuff in DOCSDIR won't be packaged in docless package (ir)regardless of their presence in staging area).

Sort USE* variables and their values

kwm edited edge metadata.
This revision is now accepted and ready to land.Nov 29 2015, 5:08 PM
This revision was automatically updated to reflect the committed changes.