graphics/waffle: Update to 1.5.2
ClosedPublic
Actions

Authored by dumbbell on Oct 31 2015, 4:43 PM.

Details

Reviewers

zeising
kwm

Commits

rP402649: graphics/waffle: Update to 1.5.2

Summary

Beside the update, explicitely enable the x11_egl platform.

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

dumbbell retitled this revision from to graphics/waffle: Update to 1.5.2.

dumbbell updated this object.

dumbbell edited the test plan for this revision. (Show Details)

dumbbell added reviewers: kwm, zeising.

Should be fine overall, but has a number of minor style bugs (reported as inline comments).

graphics/waffle/Makefile
19 ↗	(On Diff #9852)	Options-related knobs are typically expected to be found near the very end of other knobs (right before targets section starts).
22 ↗	(On Diff #9852)	Why these `USE_*` knobs are separated from the `USES` and `USE_LDCONFIG` above?
24 ↗	(On Diff #9852)	Is `LIBS` (vs. `LDFLAGS`) really correct here? If not, you might consider using `USES=localbase` instead.
27 ↗	(On Diff #9852)	These two successive `+=` statements are usually done as one. In this case it looks like it would not even cause the linewrapping.
32 ↗	(On Diff #9852)	I think this target is superfluous (i.e., stuff in `DOCSDIR` won't be packaged in docless package (ir)regardless of their presence in staging area).