Beside the update, explicitely enable the x11_egl platform.
Details
Details
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 1104 Build 1108: arc lint + arc unit
Event Timeline
Comment Actions
Should be fine overall, but has a number of minor style bugs (reported as inline comments).
| graphics/waffle/Makefile | ||
|---|---|---|
| 20–21 | Why these USE_* knobs are separated from the USES and USE_LDCONFIG above? | |
| 20–21 | Options-related knobs are typically expected to be found near the very end of other knobs (right before targets section starts). | |
| 20–21 | Is LIBS (vs. LDFLAGS) really correct here? If not, you might consider using USES=localbase instead. | |
| 21–22 | These two successive += statements are usually done as one. In this case it looks like it would not even cause the linewrapping. | |
| 26–27 | I think this target is superfluous (i.e., stuff in DOCSDIR won't be packaged in docless package (ir)regardless of their presence in staging area). | |