Move CROSS_TOOLS stuff to top of file (before bsd.compiler.mk) so that
decisions made by bsd.compiler.mk can properly affect the defaults in
src.opts.mk. Move that to after bsd.compiler.mk. Add a comment about
why we include bsd.compiler.mk here despite the fact that src.opts.mk
currently does too. Also remove bsd.arch.inc.mk that's been OBE.
Details
- Reviewers
adrian bdrewery - Commits
- rS290417: Fix CC being wrong during install* targets.
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 1039 Build 1042: arc lint + arc unit
Event Timeline
Makefile.inc1 | ||
---|---|---|
263 | Loses CROSS_TOOLCHAIN here, needs += |
Makefile.inc1 | ||
---|---|---|
263 | Hm, so doing += has the side effect of maintaining whatever was in there before this point. Should we initialise it to something specific very early on so we don't get env/var pollution? |
Makefile.inc1 | ||
---|---|---|
263 | += is right here. Good eye. |
Even for the CROSS_TOOLCHAIN_PREFIX goo? I didn't touch that but think I might need to.
CROSS_TOOLCHAIN just sets those things. It may be that we want to kill off CROSS_TOOLCHAIN_PREFIX and CROSS_COMPILER_PREFIX since aren't isn't very useful in practice. CROSS_BINUTILS_PREFIX only works because only GNU binutils or compatibly named tools are used. CROSS_COMPILER_PREFIX is less likely to work since it depends on cc, cpp, and c++ links being installed which isn't common for compilers. CROSS_TOOLCHAIN_PREFIX just sets both which is unlikely to be useful in practice.
(My original thought was that setting up a few symlinks and passing one directory would be an easier way to set all the X* variables, but in practice that didn't work out.)